[jira] [Updated] (NIFI-11108) Refactor remaining JUnit 4 tests under nifi/nifi-nar-bundles to JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-11108: Status: Patch Available (was: In Progress) > Refactor remaining JUnit 4 tests under

[jira] [Commented] (NIFI-11121) If/Else/Switch processor

2023-02-01 Thread Josh McCullough (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683196#comment-17683196 ] Josh McCullough commented on NIFI-11121: [~mosermw] ... so ... basically exactly what I was

[GitHub] [nifi] exceptionfactory commented on pull request #6915: NIFI-11126 Delete MultiPart files in ListenHTTP after processing

2023-02-01 Thread via GitHub
exceptionfactory commented on PR #6915: URL: https://github.com/apache/nifi/pull/6915#issuecomment-1412960319 It turns out that the current `ListenHTTPServlet` was not closing the Part `InputStream`. I corrected the behavior by moving `Part.getInputStream()` to the try-with-resources block

[jira] [Created] (NIFI-11131) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions

2023-02-01 Thread Daniel Stieglitz (Jira)
Daniel Stieglitz created NIFI-11131: --- Summary: Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions Key: NIFI-11131 URL: https://issues.apache.org/jira/browse/NIFI-11131

[jira] [Created] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions

2023-02-01 Thread Daniel Stieglitz (Jira)
Daniel Stieglitz created NIFI-11130: --- Summary: Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions Key: NIFI-11130 URL: https://issues.apache.org/jira/browse/NIFI-11130

[jira] [Comment Edited] (NIFI-11108) Refactor remaining JUnit 4 tests under nifi/nifi-nar-bundles to JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683165#comment-17683165 ] Daniel Stieglitz edited comment on NIFI-11108 at 2/1/23 11:00 PM: --

[jira] [Comment Edited] (NIFI-11108) Refactor remaining JUnit 4 tests under nifi/nifi-nar-bundles to JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683165#comment-17683165 ] Daniel Stieglitz edited comment on NIFI-11108 at 2/1/23 10:58 PM: --

[jira] [Comment Edited] (NIFI-11108) Refactor remaining JUnit 4 tests under nifi/nifi-nar-bundles to JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683165#comment-17683165 ] Daniel Stieglitz edited comment on NIFI-11108 at 2/1/23 10:55 PM: --

[jira] [Commented] (NIFI-11108) Refactor remaining JUnit 4 tests under nifi/nifi-nar-bundles to JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683165#comment-17683165 ] Daniel Stieglitz commented on NIFI-11108: - [~exceptionfactory] I was able to refactor many of the

[GitHub] [nifi] dan-s1 opened a new pull request, #6919: [NIFI-11108] Further changes to upgrade from JUnit 4 to JUnit 5.

2023-02-01 Thread via GitHub
dan-s1 opened a new pull request, #6919: URL: https://github.com/apache/nifi/pull/6919 # Summary [NIFI-11108](https://issues.apache.org/jira/browse/NIFI-11108) # Tracking Please complete the following tracking steps

[jira] [Updated] (NIFI-8005) ConvertExcelToCSVProcessor swallows flow file if it doesn't contain sheet with given name

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8005: --- Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (NIFI-8005) ConvertExcelToCSVProcessor swallows flow file if it doesn't contain sheet with given name

2023-02-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683161#comment-17683161 ] ASF subversion and git services commented on NIFI-8005: --- Commit

[GitHub] [nifi] exceptionfactory closed pull request #6897: [NIFI-8005] Added warning message for sheets that are not found

2023-02-01 Thread via GitHub
exceptionfactory closed pull request #6897: [NIFI-8005] Added warning message for sheets that are not found URL: https://github.com/apache/nifi/pull/6897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6892: NIFI-11059 PutBoxFile processor

2023-02-01 Thread via GitHub
turcsanyip commented on code in PR #6892: URL: https://github.com/apache/nifi/pull/6892#discussion_r1093774027 ## nifi-nar-bundles/nifi-box-bundle/nifi-box-processors/src/test/java/org/apache/nifi/processors/box/PutBoxFileTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the

[GitHub] [nifi] exceptionfactory commented on pull request #6915: NIFI-11126 Delete MultiPart files in ListenHTTP after processing

2023-02-01 Thread via GitHub
exceptionfactory commented on PR #6915: URL: https://github.com/apache/nifi/pull/6915#issuecomment-1412786764 It looks like the tests failed on Windows, reviewing... ``` Error: org.apache.nifi.processors.standard.TestListenHTTP.testMultipartFormDataRequest Time elapsed: 0.297 s

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6899: NIFI-11123: fix default value and update docs

2023-02-01 Thread via GitHub
exceptionfactory commented on code in PR #6899: URL: https://github.com/apache/nifi/pull/6899#discussion_r1093752013 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/vision/AbstractStartGcpVisionOperation.java: ## @@ -70,7

[jira] [Commented] (NIFI-11129) PutMongoBulk processor - use the more efficient bulkWrite API

2023-02-01 Thread Sebastian Rothbucher (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683142#comment-17683142 ] Sebastian Rothbucher commented on NIFI-11129: - created PR

[GitHub] [nifi] sebastianrothbucher opened a new pull request, #6918: NIFI-11129 - adding PutMongoBulk processor to use the bulkWrite API

2023-02-01 Thread via GitHub
sebastianrothbucher opened a new pull request, #6918: URL: https://github.com/apache/nifi/pull/6918 NIFI-11129 - adding PutMongoBulk processor to use the bulkWrite API for way more efficient mass updates or inserts # Summary

[GitHub] [nifi] KalmanJantner commented on pull request #6899: NIFI-11123: fix default value and update docs

2023-02-01 Thread via GitHub
KalmanJantner commented on PR #6899: URL: https://github.com/apache/nifi/pull/6899#issuecomment-1412661568 > Instead of relying on a parameter context for the output bucket we could add a property on the processor. For that property and the incoming flowfile attributes we could build a

[GitHub] [nifi] KalmanJantner commented on pull request #6899: NIFI-11123: fix default value and update docs

2023-02-01 Thread via GitHub
KalmanJantner commented on PR #6899: URL: https://github.com/apache/nifi/pull/6899#issuecomment-1412660660 > One additional note, these changes should reference a new Jira issue, not the existing Jira issue, which is already resolved. Thanks, I have created a new ticket and updated

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6915: NIFI-11126 Delete MultiPart files in ListenHTTP after processing

2023-02-01 Thread via GitHub
exceptionfactory commented on code in PR #6915: URL: https://github.com/apache/nifi/pull/6915#discussion_r1093682251 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java: ## @@

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6915: NIFI-11126 Delete MultiPart files in ListenHTTP after processing

2023-02-01 Thread via GitHub
ChrisSamo632 commented on code in PR #6915: URL: https://github.com/apache/nifi/pull/6915#discussion_r1093675510 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java: ## @@ -276,18

[jira] [Updated] (NIFI-10846) GetSmbFile issue after upgrading to Nifi 1.18.0

2023-02-01 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-10846: --- Status: Patch Available (was: In Progress) > GetSmbFile issue after upgrading to Nifi

[GitHub] [nifi] turcsanyip opened a new pull request, #6917: NIFI-10846: Added SMB Dialect and Use Encryption properties in SMB pr…

2023-02-01 Thread via GitHub
turcsanyip opened a new pull request, #6917: URL: https://github.com/apache/nifi/pull/6917 …ocessors # Summary [NIFI-10846](https://issues.apache.org/jira/browse/NIFI-10846) # Tracking Please complete the following tracking steps prior to pull request creation.

[GitHub] [nifi] mattyb149 commented on pull request #6853: NIFI-11045: Sensitive dynamic property support for parameterized quer…

2023-02-01 Thread via GitHub
mattyb149 commented on PR #6853: URL: https://github.com/apache/nifi/pull/6853#issuecomment-1412600932 Is it possible to add unit test(s) around this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] mark-bathori opened a new pull request, #6916: NIFI-11124: Add qualified path attribute to HDFS processors

2023-02-01 Thread via GitHub
mark-bathori opened a new pull request, #6916: URL: https://github.com/apache/nifi/pull/6916 # Summary [NIFI-11124](https://issues.apache.org/jira/browse/NIFI-11124) # Tracking Please complete the following tracking

[GitHub] [nifi] mattyb149 commented on pull request #6853: NIFI-11045: Sensitive dynamic property support for parameterized quer…

2023-02-01 Thread via GitHub
mattyb149 commented on PR #6853: URL: https://github.com/apache/nifi/pull/6853#issuecomment-1412587943 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (NIFI-11106) QueryRecord can fail to rollback sessions on commit failure.

2023-02-01 Thread Kevin Doran (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran updated NIFI-11106: --- Attachment: nifi-11106-sample-data-1.txt > QueryRecord can fail to rollback sessions on commit

[GitHub] [nifi] mattyb149 commented on a diff in pull request #6902: NIFI-11110: Create processor for triggering HMS events

2023-02-01 Thread via GitHub
mattyb149 commented on code in PR #6902: URL: https://github.com/apache/nifi/pull/6902#discussion_r1092405444 ## nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/TriggerHMSNotification.java: ## @@ -0,0 +1,443 @@ +/* + *

[jira] [Created] (NIFI-11128) PutMongoBulk processor - use the more efficient bulkWrite API

2023-02-01 Thread Sebastian Rothbucher (Jira)
Sebastian Rothbucher created NIFI-11128: --- Summary: PutMongoBulk processor - use the more efficient bulkWrite API Key: NIFI-11128 URL: https://issues.apache.org/jira/browse/NIFI-11128 Project:

[jira] [Created] (NIFI-11129) PutMongoBulk processor - use the more efficient bulkWrite API

2023-02-01 Thread Sebastian Rothbucher (Jira)
Sebastian Rothbucher created NIFI-11129: --- Summary: PutMongoBulk processor - use the more efficient bulkWrite API Key: NIFI-11129 URL: https://issues.apache.org/jira/browse/NIFI-11129 Project:

[jira] [Created] (NIFI-11127) PutMongoBulk processor - use the more efficient bulkWrite API

2023-02-01 Thread Sebastian Rothbucher (Jira)
Sebastian Rothbucher created NIFI-11127: --- Summary: PutMongoBulk processor - use the more efficient bulkWrite API Key: NIFI-11127 URL: https://issues.apache.org/jira/browse/NIFI-11127 Project:

[jira] [Updated] (NIFI-11108) Refactor remaining JUnit 4 tests under nifi/nifi-nar-bundles to JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-11108: Description: A search for {code:java} org.junit.Test {code} in nifi/nifi-nar-bundles

[jira] [Comment Edited] (NIFI-11126) ListenHTTP doesn't clean temporary files from multipart

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683130#comment-17683130 ] David Handermann edited comment on NIFI-11126 at 2/1/23 6:47 PM: - Thanks

[jira] [Updated] (NIFI-11126) ListenHTTP doesn't clean temporary files from multipart

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11126: Fix Version/s: 1.20.0 > ListenHTTP doesn't clean temporary files from multipart >

[jira] [Commented] (NIFI-11126) ListenHTTP doesn't clean temporary files from multipart

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683130#comment-17683130 ] David Handermann commented on NIFI-11126: - Thanks for highlighting this issue and providing the

[jira] [Assigned] (NIFI-11126) ListenHTTP doesn't clean temporary files from multipart

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-11126: --- Assignee: David Handermann > ListenHTTP doesn't clean temporary files from

[jira] [Updated] (NIFI-11126) ListenHTTP doesn't clean temporary files from multipart

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11126: Status: Patch Available (was: Open) > ListenHTTP doesn't clean temporary files from

[GitHub] [nifi] exceptionfactory opened a new pull request, #6915: NIFI-11126 Delete MultiPart files in ListenHTTP after processing

2023-02-01 Thread via GitHub
exceptionfactory opened a new pull request, #6915: URL: https://github.com/apache/nifi/pull/6915 # Summary [NIFI-11126](https://issues.apache.org/jira/browse/NIFI-11126) Updates `ListenHTTP` to delete MultiPart elements after processing to avoid leaving files in the system temporary

[jira] [Commented] (NIFI-11121) If/Else/Switch processor

2023-02-01 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683112#comment-17683112 ] Michael W Moser commented on NIFI-11121: Hi [~joshm] , have a look at the RouteOnAttribute and

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-02-01 Thread via GitHub
szaszm commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1086598334 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -137,49 +148,317 @@ void AbstractMQTTProcessor::onSchedule(const std::shared_ptrlog_error("MQTT

[jira] [Created] (NIFI-11126) ListenHTTP doesn't clean temporary files from multipart

2023-02-01 Thread Michael W Moser (Jira)
Michael W Moser created NIFI-11126: -- Summary: ListenHTTP doesn't clean temporary files from multipart Key: NIFI-11126 URL: https://issues.apache.org/jira/browse/NIFI-11126 Project: Apache NiFi

[jira] [Updated] (NIFI-11123) Fine tune GCP Vision processor's JSON Payload default value and docs

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11123: Fix Version/s: 1.20.0 > Fine tune GCP Vision processor's JSON Payload default value and

[jira] [Commented] (NIFI-11123) Fine tune GCP Vision processor's JSON Payload default value and docs

2023-02-01 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683105#comment-17683105 ] David Handermann commented on NIFI-11123: - Tagging this for inclusion in 1.20.0 since this is the

[jira] [Commented] (NIFI-11100) Cannot update controller service property of an inner process group when changing version

2023-02-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683103#comment-17683103 ] ASF subversion and git services commented on NIFI-11100: Commit

[jira] [Resolved] (NIFI-11100) Cannot update controller service property of an inner process group when changing version

2023-02-01 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-11100. Resolution: Fixed > Cannot update controller service property of an inner process group when >

[GitHub] [nifi] bbende merged pull request #6898: NIFI-11100: Limiting scope of external controller services during ver…

2023-02-01 Thread via GitHub
bbende merged PR #6898: URL: https://github.com/apache/nifi/pull/6898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (NIFI-3620) InvokeHttp should be able to send multipart forms

2023-02-01 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser resolved NIFI-3620. --- Resolution: Implemented > InvokeHttp should be able to send multipart forms >

[jira] [Commented] (NIFI-3620) InvokeHttp should be able to send multipart forms

2023-02-01 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683102#comment-17683102 ] Michael W Moser commented on NIFI-3620: --- This was implemented in NIFI-7394 in NiFi version 1.12.0 >

[GitHub] [nifi] tpalfy commented on pull request #6899: NIFI-11123: fix default value and update docs

2023-02-01 Thread via GitHub
tpalfy commented on PR #6899: URL: https://github.com/apache/nifi/pull/6899#issuecomment-1412386797 Instead of relying on a parameter context for the output bucket we could add a property on the processor. For that property and the incoming flowfile attributes we could build a custom

[jira] [Updated] (NIFI-11125) AbstracDBCPConnectionPool unset property handling

2023-02-01 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-11125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lehel Boér updated NIFI-11125: -- Status: Patch Available (was: In Progress) > AbstracDBCPConnectionPool unset property handling >

[GitHub] [nifi] Lehel44 opened a new pull request, #6914: NIFI-11125: Adding unset property handling to AbstractDBCPConnectionPool

2023-02-01 Thread via GitHub
Lehel44 opened a new pull request, #6914: URL: https://github.com/apache/nifi/pull/6914 # Summary [NIFI-11125](https://issues.apache.org/jira/browse/NIFI-11125) # Tracking Please complete the following tracking steps

[jira] [Created] (NIFI-11125) AbstracDBCPConnectionPool unset property handling

2023-02-01 Thread Jira
Lehel Boér created NIFI-11125: - Summary: AbstracDBCPConnectionPool unset property handling Key: NIFI-11125 URL: https://issues.apache.org/jira/browse/NIFI-11125 Project: Apache NiFi Issue Type:

[jira] [Created] (NIFI-11124) Add qualified path attribute to HDFS processors

2023-02-01 Thread Mark Bathori (Jira)
Mark Bathori created NIFI-11124: --- Summary: Add qualified path attribute to HDFS processors Key: NIFI-11124 URL: https://issues.apache.org/jira/browse/NIFI-11124 Project: Apache NiFi Issue

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1502: MINIFICPP-2034 Cache the results of the username lookups in ConsumeWindowsEventLog

2023-02-01 Thread via GitHub
fgerlits opened a new pull request, #1502: URL: https://github.com/apache/nifi-minifi-cpp/pull/1502 I have put this on top of #1500 to fix the docker build; that PR should be merged first. Until then, ignore the changes in the Dockerfiles and DockerBuild.sh. ---

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub
fgerlits commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093407989 ## minifi_main/MiNiFiMain.cpp: ## @@ -258,7 +259,11 @@ int main(int argc, char **argv) {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub
fgerlits commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093407232 ## minifi_main/MiNiFiWindowsService.h: ## @@ -20,10 +20,12 @@ #ifdef WIN32 #include +#include + #include "core/Core.h" void RunAsServiceIfNeeded();

[GitHub] [nifi] gresockj opened a new pull request, #6913: NIFI-11122: Allowing provided parameter contexts to be inherited afte…

2023-02-01 Thread via GitHub
gresockj opened a new pull request, #6913: URL: https://github.com/apache/nifi/pull/6913 …r context creation # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the

[jira] [Created] (NIFI-11123) Fine tune GCP Vision processor's JSON Payload default value and docs

2023-02-01 Thread Kalman Jantner (Jira)
Kalman Jantner created NIFI-11123: - Summary: Fine tune GCP Vision processor's JSON Payload default value and docs Key: NIFI-11123 URL: https://issues.apache.org/jira/browse/NIFI-11123 Project: Apache

[jira] [Updated] (NIFI-9163) Refactor nifi-websocket-bundle to use JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-9163: --- Summary: Refactor nifi-websocket-bundle to use JUnit 5 (was: Refactor nifi-websock-bundle to

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1500: MINIFICPP-2036 Use the new ccache directory in alpine 3.16

2023-02-01 Thread via GitHub
adamdebreceni commented on code in PR #1500: URL: https://github.com/apache/nifi-minifi-cpp/pull/1500#discussion_r1093361034 ## docker/Dockerfile: ## @@ -72,18 +72,17 @@ ENV MINIFI_VERSION ${MINIFI_VERSION} RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G ${USER} -g

[jira] [Comment Edited] (NIFI-9131) Refactor nifi-ldap-iaa-providers-bundle to use JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683060#comment-17683060 ] Daniel Stieglitz edited comment on NIFI-9131 at 2/1/23 3:06 PM:

[jira] [Commented] (NIFI-9131) Refactor nifi-ldap-iaa-providers-bundle to use JUnit 5

2023-02-01 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683060#comment-17683060 ] Daniel Stieglitz commented on NIFI-9131: [~mike.thomsen] [~exceptionfactory] I found that Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1500: MINIFICPP-2036 Use the new ccache directory in alpine 3.16

2023-02-01 Thread via GitHub
fgerlits commented on code in PR #1500: URL: https://github.com/apache/nifi-minifi-cpp/pull/1500#discussion_r1093346412 ## docker/Dockerfile: ## @@ -72,18 +72,17 @@ ENV MINIFI_VERSION ${MINIFI_VERSION} RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G ${USER} -g ""

[jira] [Updated] (NIFI-11100) Cannot update controller service property of an inner process group when changing version

2023-02-01 Thread Matt Gilman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-11100: --- Fix Version/s: 1.20.0 > Cannot update controller service property of an inner process group when >

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1497: MINIFICPP-1869 Metrics-related refactoring

2023-02-01 Thread via GitHub
adamdebreceni commented on code in PR #1497: URL: https://github.com/apache/nifi-minifi-cpp/pull/1497#discussion_r1093282405 ## libminifi/src/FlowController.cpp: ## @@ -205,13 +177,12 @@ int16_t FlowController::stop() { * -Stopping the schedulers doesn't actually quit the

[jira] [Updated] (MINIFICPP-1949) ConsumeWindowsEventLog should have the identifier regex compiled during onSchedule

2023-02-01 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-1949: --- Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1501: MINIFICPP-1887 Add default connection size limits

2023-02-01 Thread via GitHub
martinzink opened a new pull request, #1501: URL: https://github.com/apache/nifi-minifi-cpp/pull/1501 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1457: MINIFICPP-1979 Use Coroutines with asio

2023-02-01 Thread via GitHub
martinzink commented on code in PR #1457: URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1093236625 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -130,369 +145,179 @@ void PutTCP::onSchedule(core::ProcessContext* const context,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1500: MINIFICPP-2036 Use the new ccache directory in alpine 3.16

2023-02-01 Thread via GitHub
adamdebreceni commented on code in PR #1500: URL: https://github.com/apache/nifi-minifi-cpp/pull/1500#discussion_r1093229611 ## docker/Dockerfile: ## @@ -72,18 +72,17 @@ ENV MINIFI_VERSION ${MINIFI_VERSION} RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G ${USER} -g

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1485: MINIFICPP-2024 Refactor repository hierarchy

2023-02-01 Thread via GitHub
szaszm commented on code in PR #1485: URL: https://github.com/apache/nifi-minifi-cpp/pull/1485#discussion_r1065909379 ## libminifi/src/core/repository/VolatileContentRepository.cpp: ## @@ -86,7 +89,7 @@ std::shared_ptr VolatileContentRepository::write(const minifi::R if

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub
adamdebreceni commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093152156 ## minifi_main/MiNiFiMain.cpp: ## @@ -258,7 +259,11 @@ int main(int argc, char **argv) {

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub
szaszm commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093130269 ## minifi_main/MiNiFiWindowsService.h: ## @@ -20,10 +20,12 @@ #ifdef WIN32 #include +#include + #include "core/Core.h" void RunAsServiceIfNeeded();

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub
szaszm commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093130269 ## minifi_main/MiNiFiWindowsService.h: ## @@ -20,10 +20,12 @@ #ifdef WIN32 #include +#include + #include "core/Core.h" void RunAsServiceIfNeeded();

[jira] [Commented] (NIFI-2523) Add an "Undo" to the User Interface

2023-02-01 Thread jules (Jira)
[ https://issues.apache.org/jira/browse/NIFI-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682915#comment-17682915 ] jules commented on NIFI-2523: - [~joshm] the flow is archived at each modification of the flow, and by default