[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-25 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190885459 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-25 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190885264 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-25 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190885214 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2738: NIFI-5233 - Add EL support with Variable Registry s...

2018-05-25 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2738#discussion_r190882563 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java

[GitHub] nifi issue #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2737 I'm not too familiar with the deep internals of the framework either. What we've seen is that with the records API it just makes sense to leverage the provenance system because it already tracks

[GitHub] nifi pull request #2738: NIFI-5233 - Add EL support with Variable Registry s...

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2738#discussion_r190710420 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 @pvillard31 @mattyb149 I changed MockPropertyValue's `evaluateExpressionLanguage(FlowFile)` to AFAICT finally fix the issue. It only shows up on processors like this one where incoming

[GitHub] nifi pull request #2448: NIFI-4838 Added configurable progressive commits to...

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2448#discussion_r190665372 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java --- @@ -51,14

[GitHub] nifi pull request #2448: NIFI-4838 Added configurable progressive commits to...

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2448#discussion_r190658948 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/GetMongoIT.java --- @@ -67,20

[GitHub] nifi pull request #2448: NIFI-4838 Added configurable progressive commits to...

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2448#discussion_r190658775 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2448: NIFI-4838 Added configurable progressive commits to...

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2448#discussion_r190658748 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 @pvillard31 this should be ready to merge now. Last time I tried it out, it worked in a running flow. ---

[GitHub] nifi issue #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2737 Not sure if I like that approach. The beauty of what we did was it just puts the data into the provenance repository and there aren't that many flowfiles to track. Maybe a few hundred thousand

[GitHub] nifi issue #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2737 I'm not sure how that'd work out because you need to actually read the flowfiles and calculate the stats. ---

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2737 NIFI-5231 Added RecordStats processor. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2699: [NIFI-5192] allow expression language in Schema File prope...

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2699 @bartektartanus It fails `TestValidateXml`. If you run those tests, you'll see that your update doesn't include the `evaluateExpressionLanguage` calls that are needed to pass validation. So

[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2705 @mattyb149 @ottobackwards did a review on this one and approved (but isn't a committer). His judgment is usually spot on if you want to sign off. ---

[GitHub] nifi issue #2616: NIFI-5052 Added DeleteByQuery ElasticSearch processor.

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2616 Thanks and np. We need more committers :) ---

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190230641 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190227868 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190227792 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190232378 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestAttributesToCSV.java

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190232174 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestAttributesToCSV.java

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190227552 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2705 @joewitt @ottobackwards gave it a +1 and travis likes it. Can you merge? ---

[GitHub] nifi issue #2616: NIFI-5052 Added DeleteByQuery ElasticSearch processor.

2018-05-23 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2616 @mattyb149 can we close this out? It's blocking me from fleshing out the rest of the CRUD capabilities around the new client service. ---

[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-22 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 changed the query model per the discussion above and changed the tests to be Groovy so that the inline JSON, etc. would be a lot cleaner to read. ---

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r189753159 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r189727653 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r189727019 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r189705031 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ottobackwards I'll add user-defined headers and basic auth support, but that's it until there's a discussion around a HTTP Connection Service. I think that would be the place to go crazy

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r189580436 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r189580389 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ottobackwards @ijokarumawak Added support for the new ProxyConfigurationService. Would appreciate a review. ---

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2704 @trixpan @ijokarumawak There are two other tickets referenced, 4196 and 4175(?) in the commit list for this PR. Before I keep squashing, I want to confirm that you want me to keep going and put 3

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2704 @ijokarumawak I'm going to start reviewing this. Once we get this done, I could use a hand with a review on [this](https://github.com/apache/nifi/pull/2723) lookup service I wrote which I'm

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ottobackwards I think I might just go ahead and refactor that code now and get it done in this PR. ---

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ottobackwards I grabbed a bunch of code from InvokeHttp and did a little copy pasta. Please take a look when you get a chance. I think moving the copy pasta into a shared utility package

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-19 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 InvokeHttp has a lot of options, so that might be worth splitting it into an initial merge and then an improvement that comes in 1.8. ---

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-05-19 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2723 NIFI-5214 Added REST LookupService Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #2619: NIFI-5059 Updated MongoDBLookupService to be able t...

2018-05-19 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2619#discussion_r189434124 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBLookupService.java --- @@ -52,68

[GitHub] nifi issue #2619: NIFI-5059 Updated MongoDBLookupService to be able to detec...

2018-05-19 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2619 @pvillard31 @mattyb149 I updated this to have a clean separation between the controller and lookup service code and subclassed the lookup service from SchemaRegistryService. Can one of you do

[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 I converted it over to be a subclass of `SchemaRegistryService`. Let me know if it needs anything else. ---

[GitHub] nifi issue #2714: NIFI-5145 Changed the override in MockPropertyValue to use...

2018-05-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2714 @mattyb149 Updated it per our email thread about this. ---

[GitHub] nifi pull request #2714: NIFI-5145 Changed the override in MockPropertyValue...

2018-05-17 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2714 NIFI-5145 Changed the override in MockPropertyValue to use a better w… …ay of passing over null flowfiles in evaluateExpressionLanguage. Thank you for submitting a contribution

[GitHub] nifi issue #2702: Added Apache Pulsar processors

2018-05-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2702 @joewitt @markap14 @bbende Can one of you skim through @david-streamlio's use of controller services and let me know if you think he should refactor the names? My gut feeling is that he can

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-05-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r188938042 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/pool/ResourcePoolImpl.java --- @@ -0,0

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-05-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r188922684 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/.gitignore --- @@ -0,0 +1,5 @@ +.project --- End diff -- You should be able to get rid

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-05-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r188922865 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/pom.xml --- @@ -0,0 +1,40 @@ + + +http://maven.apache.org/POM

[GitHub] nifi issue #2712: NIFI-5197 Fixed a bunch of EL scope bugs.

2018-05-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2712 @mattyb149 @markap14 @pvillard31 this is semi-blocking 2-3 of my commits. They need to be rebased off of it so I can clean up the hack cited in 5145 from them. If you could do a quick review, I'd

[GitHub] nifi issue #2712: NIFI-5197 Fixed a bunch of EL scope bugs.

2018-05-16 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2712 @mattyb149 Recreated it. I thought I had fubar'd git, but it turned out to just be a sync issue between ASF and GitHub. ---

[GitHub] nifi pull request #2712: NIFI-5197 Fixed a bunch of EL scope bugs.

2018-05-16 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2712 NIFI-5197 Fixed a bunch of EL scope bugs. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2706: NIFI-5197 Fixed a bunch of EL scope bugs in the Mongo proc...

2018-05-16 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2706 Something weird happened with the rebase. Killing this and starting over... ---

[GitHub] nifi pull request #2706: NIFI-5197 Fixed a bunch of EL scope bugs in the Mon...

2018-05-16 Thread MikeThomsen
Github user MikeThomsen closed the pull request at: https://github.com/apache/nifi/pull/2706 ---

[GitHub] nifi pull request #2706: NIFI-5197 Fixed a bunch of EL scope bugs in the Mon...

2018-05-16 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2706#discussion_r188746508 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java

[GitHub] nifi pull request #2706: NIFI-5197 Fixed a bunch of EL scope bugs in the Mon...

2018-05-16 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2706#discussion_r188743200 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java

[GitHub] nifi issue #2707: NIFI-5200: Fixed bug that caused the wrong InputStream to ...

2018-05-16 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2707 @mattyb149 +1 LGTM. I can merge. ---

[GitHub] nifi pull request #2672: NIFI-5145 Made MockPropertyValue.evaluateExpression...

2018-05-16 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2672#discussion_r188631087 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/GetHBase.java --- @@ -147,14 +146,6

[GitHub] nifi issue #2706: NIFI-5197 Fixed a bunch of EL scope bugs in the Mongo proc...

2018-05-16 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2706 This one is dependent on 5145 being merged. ---

[GitHub] nifi pull request #2706: NIFI-5197 Fixed a bunch of EL scope bugs in the Mon...

2018-05-16 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2706 NIFI-5197 Fixed a bunch of EL scope bugs in the Mongo processors. NIFI-5197 Replaced a bunch of expressionLanguageSupported(true) statements with the right scope. Thank you

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2672 [Added a Jira ticket](https://issues.apache.org/jira/browse/NIFI-5197) to track the issue with the invalid scope bugs. ---

[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2705#discussion_r188393536 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2672 @mattyb149 I just changed the override to be the one without a parameter. I agree that there should be a task for squashing the scope bugs, but do the few that got squashed here need to be cherry

[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-15 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2705 NIFI-5169 Upgrade to JSONPath 2.4 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #2702: Added Apache Pulsar processors

2018-05-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2702 Don't worry about others' build errors for now. Master might just be a little off. TBH, we can even merge the code if the build is failing for reasons others than your commits so don't worry

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2704 @ijokarumawak haven't had a chance to take a look at this, but have you tried it against Solr and Elastic yet? I think the latter's APIs do their own proxy management so that might need a little

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2672 @markap14 I added a detailed comment describing why I did what I did and fixed a few processors that had invalid scopes applied to their properties. Build seems totally fine now. Let me know

[GitHub] nifi pull request #2672: NIFI-5145 Made MockPropertyValue.evaluateExpression...

2018-05-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2672#discussion_r188126334 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java --- @@ -202,6 +203,9 @@ public PropertyValue evaluateAttributeExpressions

[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...

2018-05-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2542 @ijokarumawak I went back and looked at the Jira ticket again, and my interpretation is that what I saw in the screenshots above (with the graph) matches your description of the behavior you

[GitHub] nifi issue #1955: NIFI-4136 Add a failure option to unmatch behavior options...

2018-05-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/1955 @ottobackwards can you compare this against your latest changes and see if it's still needed? ---

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r188055672 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #2699: [NIFI-5192] allow expression language in Schema Fil...

2018-05-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2699#discussion_r188045964 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateXml.java --- @@ -72,6

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 @joewitt I think if he were to rebase and drop [this commit](https://github.com/apache/nifi/pull/2614/commits/99a980cc1e6bbb45e64fb3431545023eefb8522c) it should fix that. What do you think? ---

[GitHub] nifi issue #2671: NiFi-5102 - Adding Processors for MarkLogic DB

2018-05-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2671 @vivekmuniyandi Unrelated, but I don't have your email: consider adding a MarkLogicLookupService in a future sprint. You can look at HBaseLookupService and MongoDBLookupService as examples. Might

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 @david-streamlio Ok, I think I figured out what happened. At some point, it looks like you accidentally did a pull on upstream master into your branch. The fact that you keep having over 200

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 Huh, I just checked out your latest branch and it's clean as a whistle WRT rebasing and appears 100% up to date w/ the upstream master. So not sure what the heck is going on here. Try doing

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 Ok, I'll take a look. Worst comes to worst, we cherry-pick the heck out of your commits and play a game of hacky sack with Git and commits to get you back on track. ---

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2672 @pvillard31 can you take a look? ---

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187795885 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187795865 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/resources/default-grok-patterns.txt --- @@ -0,0 +1,115

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 At that point, this should work now to clear things up hopefully: `git push origin --force NIFI-4914` ---

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 Bingo! That's what you should be seeing now. Fix the merge conflicts, `git add` the files and continue (and repeat until it's done) ---

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 Pretty sure we found the culprit: > Davids-MacBook-Pro:nifi david$ git rebase That should be `git rebase master`. Not sure what git thinks it's doing, but it's clearly not do

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 Also, run `git rebase --continue` on that branch and tell us what happens. Copy and paste the output as "code" in the combox (code Markdown helper is the <> button) ---

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 I pulled your branch and got a lot of merge conflicts when I tried rebasing against master. I am pretty sure that @mattyb149 is right or on the right track. When you followed those four steps

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 Yeah, I think @mattyb149 is right about that. I just pulled your branch again, did a rebase against master and there was an explosion of conflicts. Once you resolve those, you have to do `git

[GitHub] nifi issue #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2675 @markap14 are you good with this or do you want some additional eyes on it? ---

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r187770744 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187770374 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187770394 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/resources/default-grok-patterns.txt --- @@ -0,0 +1,115

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187720132 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi pull request #2594: NIFI-5024 Resolves deadlock in ExecuteStreamCommand...

2018-05-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2594#discussion_r187743134 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java

[GitHub] nifi pull request #2594: NIFI-5024 Resolves deadlock in ExecuteStreamCommand...

2018-05-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2594#discussion_r187742376 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2672 @markap14 Any feedback? ---

[GitHub] nifi pull request #2672: NIFI-5145 Made MockPropertyValue.evaluateExpression...

2018-05-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2672#discussion_r187481205 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java --- @@ -202,6 +203,9 @@ public PropertyValue evaluateAttributeExpressions

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-10 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2614 @david-streamlio don't feel rushed, I was just checking in to see if you were still tracking this. ---

[GitHub] nifi pull request #2672: NIFI-5145 Made MockPropertyValue.evaluateExpression...

2018-05-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2672#discussion_r187470996 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi issue #2518: NIFI-4637 Added support for visibility labels to the HBase...

2018-05-10 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2518 @ijokarumawak version reverted and building... ---

[GitHub] nifi issue #2518: NIFI-4637 Added support for visibility labels to the HBase...

2018-05-10 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2518 I'll add a patch to revert the version # on the client lib. Since HDP is on 1.1.2 and CDH 5.14 is still on 1.2, I don't think it's safe to jump up to anything higher than a 1.2 client anyway. ---

<    1   2   3   4   5   6   7   8   9   10   >