Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1589#discussion_r183454230
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1589#discussion_r183451963
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r183417572
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2243#discussion_r183388072
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -278,8
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2243#discussion_r183382982
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2243#discussion_r183384397
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -278,8
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2243#discussion_r183383744
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -278,8
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2616
@JPercivall if you have any time, do you think you could take a look at
this?
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2638#discussion_r183256566
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
---
@@ -350,6 +350,8 @@ private static
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2614
When I added it to nifi-assembly, I got this error on startup:
```
java.util.ServiceConfigurationError: org.apache.nifi.processor.Processor:
Provider
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235809
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/pom.xml ---
@@ -0,0 +1,67 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234826
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235065
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183233581
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234943
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235109
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234762
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183209203
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234572
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183209029
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-nar/src/main/resources/META-INF/NOTICE
---
@@ -0,0 +1,612 @@
+nifi-druid
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183208823
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/pool/PoolableResource.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235163
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsar_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183208994
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/pool/ResourceFactory.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183210297
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234732
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234849
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235146
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235215
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/RecordBasedConst.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234861
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/InFlightMessageMonitor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234779
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235123
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234534
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235251
--- Diff: nifi-nar-bundles/pom.xml ---
@@ -93,6 +93,7 @@
nifi-spark-bundle
nifi-atlas-bundle
nifi-druid-bundle
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183208828
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/PulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183209058
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234539
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183209099
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183235033
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsarRecord_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183234838
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar_1_X.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183209046
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183209071
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2614#discussion_r183208835
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/PulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2614
@david-streamlio I'm in the processor of working through a code review now.
In the mean time, I found that you did not add the NAR reference to
nifi-assembly/pom.xml. Can you correct that?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2561
@abhinavrohatgi30 You have a merge conflict in this branch. If you resolve
it, I'll help @bbende finish the review.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak changes pushed. Ready for review.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2638
+1 LGTM. Passed the build and it matches my rough understanding of the
issues w/ Oracle as well. I'm good to merge this if you don't think it needs
further review.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak Disregard that last comment. I apparently forgot to update
the EL support. Will get that done today.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak New build pushed. Sorry about the squash commit wiping out
the existing comments, but I had to do it in order to save time and stress on
integrating the EL changes and things like
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r183030677
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/test/java/org/apache/nifi/hbase/VisibilityIT.java
---
@@ -0,0 +1,510
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r183014568
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/VisibilityFetchSupport.java
---
@@ -0,0 +1,53
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@bbende @ijokarumawak To move that IT into the client test package, I have
to upgrade the client's hbase-client dependency to 1.2.X from 1.1.X. Do you see
anything wrong with doing that? At
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r182806554
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/test/java/org/apache/nifi/hbase/VisibilityIT.java
---
@@ -0,0 +1,510
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
Thanks for jumping on this @ijokarumawak I'll try to find some time today
to resolve and push a fix.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r182792431
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/VisibilityFetchSupport.java
---
@@ -0,0 +1,53
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r182788174
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel Sounds good. Make sure it includes the request
documentation as well. That's going to be a big deal in making this easy for
new users to use. Thanks.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2572
@claudiu-stanciu I think this will be ready to merge once you get that
change in.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2546
@mattyb149 when I rebased this commit, I added fixes for the integration
tests so they could run again with the new way of handling EL.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2636
@zenfenan have you had a chance to run this against a live HBase cluster?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
Have you had a chance to add the missing provenance tracking?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel I missed those tests for some reason. Basically I was just
looking for something that goes into deep pagination behavior. Disregard for
now. Thanks.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181499869
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java
---
@@ -0,0 +1,584
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181499538
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java
---
@@ -0,0 +1,584
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2601
@ottobackwards Follow up from your reference to this in the `QuerySolr`
PR...
If you've got a use case where you need to get stats from ES, check out
`JsonQueryElasticsearch`. It
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@ottobackwards
> @JohannesDaniel If there are no results from a page request, does that
mean there is no output? I ask because I have a PR for that use case with
QueryElasticsearchH
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel I didn't see a test that tests deep pagination. If you
don't have one, please add one. You can just throw garbage data in there like
random strings. Also, you should ad
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181360753
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java
---
@@ -0,0 +1,584
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181359744
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java
---
@@ -0,0 +1,584
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181360837
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java
---
@@ -0,0 +1,584
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181360808
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java
---
@@ -0,0 +1,584
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181354337
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/resources/docs/org/apache/nifi/processors/solr/QuerySolr/additionalDetails.html
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r181359931
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java
---
@@ -0,0 +1,584
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
Ok. Verified with a test run that it appears to run fine against a vanilla
Solr installation.
Docker: `docker run --name testsolr -p 8983:8983 solr:latest solr-demo
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
> should be an expectation that there is some commonality between them.
Solr and ES are increasingly used for different use cases these days. Solr
tends to be more commonly used for p
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
Builds just fine for me locally. If you're still having build problems, try
deleting everything under org/apache/nifi from .m2/repository in your home
folder.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2616
Thanks @zenfenan
@mattyb149 @pvillard31 What do you think? Ready to merge?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
Ok. I'll take a look and let you know sometime in a little while. Got some
other things on my plate at the moment.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2616
@zenfenan Done. Do you have commit privileges? Had to ask because I'm not
sure how up to date the team page is on apache.org.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel also, you don't need to wait for a new build to push the
changes. Overwriting everything will schedule the job to be killed and a new
one started.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel nope. If you did a rebase, those new commits would be
behind your commits, not merged ahead of them. What a rebase does is it sets
aside your commits, brings the base pointer for
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel see my earlier comment about rebasing. You **cannot** just
do `git merge master` into another branch like that since master is the
foundation of that branch. Don't worry, t
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel go ahead and check in the change even if it's broken. I'll
help take a look.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2546#discussion_r181038091
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/QueryHelper.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2546#discussion_r181036257
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/DeleteGridFS.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2546#discussion_r181035977
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/AbstractGridFSProcessor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2546#discussion_r181035376
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
Do this:
1. git checkout master
2. git pull upstream master (whatever you call github.com/apache/nifi
master)
3. git checkout NIFI-4516
4. git rebase master
5. git push
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2616#discussion_r180870902
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2616#discussion_r180870831
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
---
@@ -69,11 +69,11 @@
2.6
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2616#discussion_r180870941
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2616#discussion_r180870855
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
---
@@ -137,7 +149,7
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2616#discussion_r180870705
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@timhallinflux Based on my extremely limited knowledge of what InfluxDB can
do, I don't know if even the U or D from CRUD are really applicable to InfluxDB
for example. What I'd like
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@timhallinflux if you don't mind, please take some time to think about
additional NiFi-related use cases and either post them to the dev mailing list
or add them as Jira tickets.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2541
@jonyosn To clarify a bit, the reason why this is the wrong venue for your
issue is that this is for proposed changes to NiFi. The majority of the
community will never see the issues you have and
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel just do a rebase against master. You shouldn't use `git
merge master` for something like this. If you want to do a big squash event to
make the rebase easier, go ahead.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2541
@jonyosn Please close this. I don't see any patch from you, and this is not
the place to raise an issue. If you need help, you can go to the user mailing
list found on [the NiFi website]
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2572#discussion_r180735170
--- Diff:
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2625#discussion_r180727687
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2625#discussion_r180728070
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
701 - 800 of 1387 matches
Mail list logo
