Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
@bbende @MikeThomsen Thanks for reviewing the pull request
---
Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
I'm really sorry, it might take a while, I'm on a vacation and away from my
workstation. I'll keep you updated as soon as I am back.
---
Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
Hi, I've looked at the comments and I've made the following changes as part
of the latest commit that cover all the comments :
1. Fixed the issue with Nested Records (The issue came
Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
@bbende I'll have a look at this and write test cases accordingly.
---
Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
Hi @bbende , I've brought it down to a single commit, can you have a look
at it now?
---
Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
I'm done with the changes that @bbende and @MikeThomsen have suggested
---
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r176208789
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r176208228
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r176207854
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r176206589
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0
Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
Sorry, instead of doing the force push i resolved conflicts and did a push,
can i now do the rebase again on the current commit or will i have to add a new
commit inorder to rebase from
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175883171
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175882819
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175840062
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175839474
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175816508
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175801577
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175799302
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175797163
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/test/java/org/apache/nifi/processors/solr/util/MockRecordParser.java
Github user abhinavrohatgi30 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175796878
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0
Github user abhinavrohatgi30 commented on the issue:
https://github.com/apache/nifi/pull/2561
NIFI-4035 Adding a PutSolrRecord Processor that reads NiFi Records and
indexes them into Solr as SolrDocuments.
---
GitHub user abhinavrohatgi30 opened a pull request:
https://github.com/apache/nifi/pull/2561
NIFI-4035 Implement record-based Solr processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
22 matches
Mail list logo
