Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r223046927
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r223045178
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r223045802
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r223044277
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r223043551
--- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/pom.xml
---
@@ -0,0 +1,87 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221975264
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221470898
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
@MikeThomsen - Regarding your graph output questions - Can you please let
me know what are the commands/files that were ingested for above output ?
---
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221104284
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/test/java/org/apache/nifi/processors/neo4j/TestNeo4JCyperExecutor.java
---
@@ -0,0
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221104258
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221103863
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221103455
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221101649
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221100711
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r221100628
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
Rebased against master.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@ijokarumawak - Thanks for your comments. I will checkout the pointers you
have given. Mans
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
@MikeThomsen - There is a docker compose file in the nifi-neo4j-examples
project mentioned above. Note that to avoid any conflict with standalone
server - the ports exposed in docker compose
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r217887181
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java
---
@@ -0,0
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r217887154
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@markap14 @ijokarumawak @jzonthemtn and Nifi Team: Please let me know if
you have any additional comments for this processor. Thanks.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
@ottobackwards Thanks for your comments.
@joewitt - Please let me know if you have any advice/pointers for me.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
@ottobackwards - I've update the code/documentation based on your feedback.
Please let me know if you have any additional advice for me.
Mans
---
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r215476392
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/test/java/org/apache/nifi/processors/neo4j/ITNeo4JCyperExecutor.java
---
@@ -0,0
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r215476339
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java
---
@@ -0,0
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
Hello @ottobackwards
I've documented the steps for setting up neo4j and testing this processor
in a project
[nifi-neo4j-examples](https://github.com/mans2singh/nifi-flow-examples/tree
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
Hi @ottobackwards @joewitt
I've renamed the bundle based on your feedback. Please let me know if you
have any more comments/feedback.
Thanks for your advice.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2956
@ottobackwards - I am open to changing the name to your recommendation.
Mans
---
GitHub user mans2singh opened a pull request:
https://github.com/apache/nifi/pull/2956
NIFI-5537 Create Neo4J cypher execution processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
Hi @ijokarumawak -
I've merged your changes. Please let me know if you have any more
recommendations.
Thanks for your help.
Mans
---
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r200638844
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/pom.xml
---
@@ -0,0 +1,114 @@
+
+
+http
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r199823948
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/pom.xml
---
@@ -0,0 +1,114 @@
+
+
+http
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r199823718
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/pom.xml
---
@@ -0,0 +1,114 @@
+
+
+http
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@ijokarumawak - Just following-up:
1. Regarding implementing record look up service - I believe that the
processor and a record service lookup can be separate components useful
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r196994774
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@ijokarumawak -
I've created two flow templates for testing the DL4J processor.
The first with a file input and file output. The second flow reads a row
from rdbms based on id
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@joewitt - I will remove the nar from the assembly. Let me know if there
is any additional feedback. Thanks.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@ijokarumawak - I was thinking that the processor will be used as a
transformer (predictor) and there would be a correlation attribute in the flow
file which would be used to associate the results
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r194944047
--- Diff: nifi-assembly/pom.xml ---
@@ -379,6 +379,12 @@ language governing permissions and limitations under
the License. -->
1.
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r194943820
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/test/resources/classification_test.txt
---
@@ -0,0 +1,100
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@ijokarumawak -
Thanks for your feedback. I was away for a few days and will respond to
your comments soon.
Mans
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@markap14, NIFI team
Just wondering if you have any feedback on this processor.
Thanks
---
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187663098
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
@markap14 -
Thanks for your prompt review and advice.
I've updated the code based on your review and am looking forward to
your/other members feedback.
Thanks again
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187655735
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187655641
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187655109
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/test/resources/classification_test.txt
---
@@ -0,0 +1,100
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187654464
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187654383
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187654258
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187654197
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187653950
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187653982
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187653539
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187653485
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2686
Good Morning Nifi Folks:
The appveyor build is passing for this PR but travis-ci build is failing
with the following message:
`[ERROR] Failed to execute goal
GitHub user mans2singh opened a pull request:
https://github.com/apache/nifi/pull/2686
NIFI-5166 - Deep learning classification and regression processor witâ¦
â¦h deeplearning4j
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen @joewitt - Thanks for your help in making this contribution
possible.
@timhallinflux - Please let me know if you have any additional enhancements
possible. I will contact
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen -
I've updated the code (added expression language scope and updated tests)
based your review comments. The integration tests are passing.
Please let me know
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
Thanks @MikeThomsen for your reveiw/advice. Also thanks @timhallinflux for
the pointers on influxdb sandbox.
Please let me know if there is other feedback.
Mans
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen -
I have updated the test cases regarding usage of assertions. Let me know
if there is anything else outstanding.
Thanks
---
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r179012098
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r179012073
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r179012036
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITExecuteInfluxDBQuery.java
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen -
I've updated the code based on your comments. Let me know if you have any
more recommendations.
Thanks
---
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178480359
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178480131
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178480144
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/AbstractITInfluxDB.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178480116
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178480026
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178479805
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178479729
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178479713
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r178479664
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen - I've updated the code based on your comments (added check
for query result null, changed scheduled query property name). One note, if we
use the influxdb-compose.xml file
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r177296540
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r177296457
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/AbstractITInfluxDB.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r177296275
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@joewitt @MikeThomsen -
I've updated the code based on your comments.
I've also added a docker gist
[influxdb-compose.xml](https://gist.github.com/mans2singh
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974725
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/AbstractITInfluxDB.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974663
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974557
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974503
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974419
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974380
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974361
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974332
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974260
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2562#discussion_r176974126
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
Hi @MikeThomsen - Thanks for your review and comments.
I will work on your and @joewitt 's recommendation this weekend.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
Hi Nifi Team:
Please let me know your suggestions/recommendations on this InfluxDB Query
Processsor.
Thanks
---
GitHub user mans2singh opened a pull request:
https://github.com/apache/nifi/pull/2562
NIFI-4927 - InfluxDB Query Processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
Thanks @MikeThomsen @pvillard31 @mattyb149 @joewitt @jskora and everyone
for your advice/support.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
@pvillard31 @mattyb149 @MikeThomsen
I've added expression language support for username and password.
Please let me know if there is any other recommendation.
Thanks
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
@pvillard31 -
You were right - After renaming the integration tests they don't get
executed by default mvn install. Also removed test profile from pom.xml as
recommended
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2101#discussion_r169968256
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/pom.xml ---
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
Hi @MikeThomsen @mattyb149 @joewitt
I believe I have implemented all the review changes. Please let me know if
there is anything I have missed or you have any additional recommendations
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2101#discussion_r165818221
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/PutInfluxDB.java
---
@@ -0,0
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
@MikeThomsen -
If the fields, tags and timestamp for a measurement are the same, they are
considered to be the same record.
Regarding size limit - I did not find any mention
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
@mattyb149 @MikeThomsen
Please let me know if you have any addiional comments/recommendations for
this processor.
Thanks
---
1 - 100 of 159 matches
Mail list logo
