Github user milanchandna commented on the issue:
https://github.com/apache/nifi/pull/2158
@jzonthemtn @jzonthemtn @pvillard31 Please review.
---
Github user milanchandna commented on the issue:
https://github.com/apache/nifi/pull/2158
Can I please get some feedback here. Thanks.
---
Github user milanchandna commented on the issue:
https://github.com/apache/nifi/pull/2158
@joewitt, @jzonthemtn @pvillard31 - Hey, did you guys got a chance to look
at this?
---
Github user milanchandna commented on the issue:
https://github.com/apache/nifi/pull/2180
Yes I reviewed, changes looks good. But I am myself a fresh contributor so
IMO you should wait for expert review to get this merged.
---
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r143422216
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/ListADLSFile.java
---
@@ -0,0 +1,289
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r143404820
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/ListADLSFile.java
---
@@ -0,0 +1,289
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r143404785
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/ListADLSFile.java
---
@@ -0,0 +1,289
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r143404854
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/PutADLSFile.java
---
@@ -0,0 +1,267
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r143404758
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/ADLSConstants.java
---
@@ -0,0 +1,90
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r142060479
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongoAggregation.java
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r142060366
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r142060410
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r142060476
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r142037960
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/PutADLSFile.java
---
@@ -0,0 +1,282
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r140503820
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/processors/adls/TestPutADLSFile.java
---
@@ -0,0
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r140503615
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/PutADLSFile.java
---
@@ -0,0 +1,267
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r140503030
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/ADLSConstants.java
---
@@ -0,0 +1,90
Github user milanchandna commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2158#discussion_r140502906
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/adls/ADLSConstants.java
---
@@ -0,0 +1,90
Github user milanchandna commented on the issue:
https://github.com/apache/nifi/pull/2158
Hey @pvillard31 Thanks for comments, looking into them.
Currently when I am running full build, I am getting failures in
TestMinimalLockingWriteAheadLog
Github user milanchandna commented on the issue:
https://github.com/apache/nifi/pull/2158
Removed the test resource files(as there were license issues) and resolved
their dependencies. And there were environment specific characters in test
cases. Got rid of them. Please check now.
---
Github user milanchandna commented on the issue:
https://github.com/apache/nifi/pull/2158
Thanks @joewitt
These test resource files contains Lorem Ipsum text.
But anyways I will create my own if required but dont want to delete as
they are required for an important test
GitHub user milanchandna opened a pull request:
https://github.com/apache/nifi/pull/2158
NIFI-4360 Adding support for ADLS Processors. Feature includes List, â¦
â¦Get, Put processors. Till now ADLS interaction was possible using HDFS
processors. Now users can ingress and egress
22 matches
Mail list logo
