Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3200
There should be new tests that go along with this
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3183#discussion_r238675406
--- Diff:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java
---
@@ -39,4 +39,52 @@ public static
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3183#discussion_r238675752
--- Diff:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java
---
@@ -39,4 +39,52 @@ public static
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/451
MINIFICPP-688 fix small spelling error and awkward wording
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3183
+1, LGTM
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3183#discussion_r236830742
--- Diff:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java
---
@@ -39,4 +39,44 @@ public static
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3183#discussion_r236785266
--- Diff:
nifi-commons/nifi-record-path/src/test/java/org/apache/nifi/record/path/TestRecordPath.java
---
@@ -1008,12 +1008,16 @@ public void
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3183#discussion_r236784930
--- Diff:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java
---
@@ -39,4 +39,44 @@ public static
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi-registry/pull/148
I don't want to pepper you with questions on this, is there some
documentation that goes along with this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi-registry/pull/148
What are some of the rules that can be tested? Like uploading with
duplicate names etc?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi-registry/pull/148
Would it make sense to have separate areas to store the project nars vs
other nars?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3130
Thanks for taking the time to explain further. I see what you mean. Nifi
needs a better way to get across to users when to use what processor in general.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3130
What I mean is that from a high level, it is a transformational capability,
and may be used as an alternative.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3130
Isn't this like the Jolt capability?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3095
@bbende can you change the title to refer to the correct jira, you got me
all excited about the other jira ;)
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3090
I think this general subject, and processor in particular can use some
usage documentation, maybe an additional documentation page would be a good
addition for this?
---
Github user ottobackwards closed the pull request at:
https://github.com/apache/nifi/pull/3084
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3084
Closing until re-write
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3084
@patricker
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/3084
NIFI-5689 ReplaceText does not handle end of line correctly on bufferâ¦
⦠boundary
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3070
Is there a way that the duplicated code can be shared?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3060#discussion_r224208847
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/validation
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3060#discussion_r224205938
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/validation
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3049
This looks great to me, I thought there was a specific use case for this,
if so, it might be good to have a unit or integration text that showed that
case.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3049#discussion_r223141579
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
---
@@ -339,6 +339,11 @@ public static
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r221070316
--- Diff: libminifi/include/properties/Properties.h ---
@@ -60,6 +60,9 @@ class Properties {
// Get the config value
bool get
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r221068265
--- Diff: libminifi/include/properties/Properties.h ---
@@ -60,6 +60,9 @@ class Properties {
// Get the config value
bool get
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r220403308
--- Diff: libminifi/include/c2/C2Trigger.h ---
@@ -0,0 +1,63 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2820
You can trigger a build by closing and reopening the pr.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2920
Yeah thanks @mattyb149
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2983
There are checkstyle errors not related to my pr on this pr as well.
```bash
[INFO] --- maven-checkstyle-plugin:2.17:check (check-style) @
nifi-standard-processors ---
[WARNING
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2983
https://github.com/alopresto/nifi/pull/6
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2983
https://github.com/apache/nifi/pull/2802#discussion_r199346844
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2983
Travis has the same issue :
https://api.travis-ci.org/v3/job/425055118/log.txt
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2956
@mans2singh This is great PR. +1 from me.
You still need a committer +1 though.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2983
https://github.com/alopresto/nifi/tree/NIFI-5566/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources
doesn't have that directory either. Isn't there something
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2983
```
ottofowler@Winterfell î°
~/tmp/apache-nifi-pr-2983/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test
î° î pr-2983 î° ls resources
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r215271708
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/test/java/org/apache/nifi/processors/neo4j/ITNeo4JCyperExecutor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r215271238
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java
---
@@ -0,0
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2983
[INFO] Running org.apache.nifi.security.util.crypto.HashServiceTest
[ERROR] Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
0.179 s <<<
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2956
One question I have, do we have to be concerned with which version of neo4j
works with the driver version we are using? Does that need to be documented?
"Known to work with versions ."?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2956
Thanks @mans2singh. I'll definitely try to run through this.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2983#discussion_r215020413
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HashAttribute.java
Github user ottobackwards closed the pull request at:
https://github.com/apache/nifi/pull/2806
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2806
closing, not much demand I guess.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2983#discussion_r214887528
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HashAttribute.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2980#discussion_r214883268
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/HashService.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2980#discussion_r214882758
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/HashAlgorithm.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2920#discussion_r214872646
--- Diff:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Base64Encode.java
---
@@ -0,0 +1,58
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2836
Sure. For Jira's when you want to do it yourself, I suggest assigning it.
That is my habit on the other Apache things I work with, and it will help guard
against eager beavers
Github user ottobackwards closed the pull request at:
https://github.com/apache/nifi/pull/2836
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2836
Ok, that is great. Did I miss something that _was_ in the jira?
Should I just close this PR now then?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2836
Rebased on master, and fixed typos
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2836
@alopresto, just a ping. It has been a while
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213383530
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213357727
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213357507
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213317913
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213312718
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213049169
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2968
I tested to make sure it didn't regress normal working with the Web Api
Gateway processor, but that processor doesn't modify the endpoint post client
creation anyway. Works fine, no regression
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2956
@mans2singh I'm not sure how to test this. I don't use/have neo4j. If you
know a reviewer who does, you may want to tag them. I won't be able to review
without some testing instructions
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r212960991
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBLookupService.java
---
@@ -83,6
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r212960490
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r212959015
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBLookupService.java
---
@@ -83,6
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2963
I ran this and got the html file in the target directory. This probably
needs to be documented somewhere though.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2956
That seems to be the convention from what I can see, and then there would
be multiple neo4j processors, maybe services, service-api, common utils under
there.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2956
Just a quick comment. Why not just a neo4j bundle? I think that is the
convention
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2929
I have reviewed
https://github.com/apache/nifi/pull/2748, I believe that is the better fix
for these issues. I'm going to close this PR.
---
Github user ottobackwards closed the pull request at:
https://github.com/apache/nifi/pull/2929
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2951
Ran with contrib-check, and stepped through.
@markap14 this is certainly a better fix for the issues than my other PR's.
I learned something I didn't know about the el evaluation
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2929#discussion_r210089927
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2929#discussion_r210089885
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2929#discussion_r210073665
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2929#discussion_r210073535
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2937
Built with -Pcontrib-check, verified the documentation, +1 from me, nice
work
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2937
@jtstorck I think that examples would help the user get the right one the
first time. Not a deal breaker though.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2937#discussion_r208222852
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java
---
@@ -462,11
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2937#discussion_r207983251
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java
---
@@ -462,11
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2937
@jtstorck will review.
First quick thing is to ask if you have considered adding an
additionDetails talking about why you would choose one strategy over another,
maybe with simple examples?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2933
Would it help if you would load NAR's without unpacking them to disk?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2930
I don't know if ListHDFS has additional documentation, but you may want to
think about adding an explanation and when you would want to use which, the
problems etc
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2930
We would have to make sure that prior tests and maybe new tests prove that
out @bbende as part of acceptance.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2930
Yeah, that sounds good, then have a PathFilter implementation for each
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2930
Why not have a new Property ( defaulting to the status quo anti ) for the
search strategy, and have the recursive strategy use full paths and make it opt
in?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2929
@JPercivall
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2929
NIFI-5474 ReplaceText RegexReplace evaluates payload as Expression language
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2820
As far as I can see, this PR is in great same. Good works
@PrashanthVenkatesan.
Tests and contrib tests are great. I manually tested with the sample
generator and the output looks
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r206290668
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-utils/src/main/java/org/apache/nifi/processors/network/parser/Netflowv5Parser.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r206164076
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-utils/src/main/java/org/apache/nifi/processors/network/parser/Netflowv5Parser.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r206125096
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-utils/src/main/java/org/apache/nifi/processors/network/parser/Netflowv5Parser.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2820
Also, thinking of it, the name of the Nar you have should be network
processors nar, not just network nar. When we do the controller services
(record readers) they will need a nar
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2920#discussion_r205752245
--- Diff:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Base64Decode.java
---
@@ -0,0 +1,50
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2820
OK. Contrib check and build passes.
Everything runs the way it should. My question is on the data.
The src and dest addresses are just the numbers. They are supposed to be
ip
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r205314387
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r204404608
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r204266885
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r204250561
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r204246930
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r204240871
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
1 - 100 of 345 matches
Mail list logo
