[GitHub] nifi pull request #3204: NIFI-1364 - Removed custom OCSP certificate revocat...

2018-12-05 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/3204 NIFI-1364 - Removed custom OCSP certificate revocation checking code and replaced with just using Java native implementation. Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #3034: NIFI-5479 - Fixed up dependencies to remove the WARNs caus...

2018-12-03 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/3034 > Hey, > > I'm facing this issue while trying to upgrade from 1.6.0 to 1.8.0. > > PFB the logs > > ``` > 2018-11-30 15:36:58,500 WARN [Process Cl

[GitHub] nifi issue #3102: NIFI-5737: Removing need client auth property as cluster c...

2018-10-22 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/3102 +1 Reviewed the code changes. Most of the changes were related to tests. The needClientAuth attribute is not used all that much in actual code. Tested InvokeHTTP with trust/keystores set up

[GitHub] nifi pull request #3097: Revert "NIFI-4558 - Set JKS as the default keystore...

2018-10-19 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/3097 Revert "NIFI-4558 - Set JKS as the default keystore type and truststo… …re type." This reverts commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd. Thank you for

[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...

2018-10-17 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2977 Discovered issues within the core nifi framework related to guava, zookeeper and curator. Unable to bump guava without upgrading the others. This is a bigger task that just upgrading guava. ---

[GitHub] nifi pull request #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v...

2018-10-17 Thread thenatog
Github user thenatog closed the pull request at: https://github.com/apache/nifi/pull/2977 ---

[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...

2018-10-16 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2977 Updating this PR, don't merge. ---

[GitHub] nifi pull request #3067: NIFI-5665 - Setting zookeeper's io.netty:netty tran...

2018-10-12 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/3067 NIFI-5665 - Setting zookeeper's io.netty:netty transitive dependency … …version to 3.10.6.Final. NIFI-5665 - Setting all transitive io.netty dependencies to 3.10.6.Final. NIFI

[GitHub] nifi issue #3034: NIFI-5479 - Fixed up dependencies to remove the WARNs caus...

2018-10-04 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/3034 https://issues.apache.org/jira/browse/NIFI-5479?focusedCommentId=16607187=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16607187 ---

[GitHub] nifi issue #3034: NIFI-5479 - Fixed up dependencies to remove the WARNs caus...

2018-10-04 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/3034 I did see that one, let me figure out what happened with that. ---

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-01 Thread thenatog
Github user thenatog commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r221687627 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/pom.xml --- @@ -0,0 +1,87 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi issue #3035: NIFI-5628 Added content length check to OkHttpReplicationC...

2018-09-28 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/3035 @alopresto @mcgilman Looks good to me. Ran tests and confirmed in the logs that the DELETE request is re-written as Content-Length = 0 when replicated to the rest of the cluster. Still hangs

[GitHub] nifi issue #3034: NIFI-5479 - Fixed up dependencies to remove the WARNs caus...

2018-09-26 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/3034 Let me know whether the way I've changed these dependencies is acceptable. The dependencies that were modified were causing WARN messages to be shown when NiFi started, for example

[GitHub] nifi pull request #3034: NIFI-5479 - Fixed up dependencies to remove the WAR...

2018-09-26 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/3034 NIFI-5479 - Fixed up dependencies to remove the WARNs caused by the A… …nnotationParser in Jetty. NIFI-5479 - Deleted instead of commented out. NIFI-5479 - Removed empty line

[GitHub] nifi pull request #3024: NIFI-5595 - Added the CORS filter to the templates/...

2018-09-24 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/3024 NIFI-5595 - Added the CORS filter to the templates/upload endpoint us… …ing a URL matcher. NIFI-5595 - Explicitly allow methods GET, HEAD. These are the Spring defaults when

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-14 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2983 Looks good to me. +1 ---

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-12 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2983 @alopresto Apologies, looks like I had things a bit backward. The template given was generating the dynamic content with attributes: dynamic generator_type

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-10 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2983 I am finding that the files fail for Processor Configuration 1 (Allow partial) with Flowfile B which is why I'm confused. ---

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-10 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2983 How do "Fail when no attributes present" and "Missing attribute policy" work? Using your template, "CryptographicHashAttribute (New)" processor fails fi

[GitHub] nifi issue #2980: NIFI-5147 Implement CalculateAttributeHash processor

2018-09-07 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2980 Tested out the HashAttribute processor. This all worked fine: - MD5 and creating a new attribute - MD5 and overwriting the attribute with hashed value - SHA256 and creating a new attribute

[GitHub] nifi issue #2980: NIFI-5147 Implement CalculateAttributeHash processor

2018-09-07 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2980 Reviewing.. ---

[GitHub] nifi pull request #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which...

2018-09-06 Thread thenatog
Github user thenatog commented on a diff in the pull request: https://github.com/apache/nifi/pull/2989#discussion_r215647422 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java --- @@ -502,6

[GitHub] nifi pull request #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which...

2018-09-05 Thread thenatog
Github user thenatog commented on a diff in the pull request: https://github.com/apache/nifi/pull/2989#discussion_r215294007 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -154,5 +154,20 @@ jettison

[GitHub] nifi pull request #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which...

2018-09-04 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2989 NIFI-5366 - Added ContentSecurityPolicyFilter which stops framing of … …NiFi resources. It applies the Content-Security-Policy header. This protects against clickjacking. NIFI-5366

[GitHub] nifi pull request #2982: NIFI-4558 - Set JKS as the default keystore type an...

2018-08-31 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2982 NIFI-4558 - Set JKS as the default keystore type and truststore type. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi pull request #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v...

2018-08-30 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2977 NIFI-5562 - Upgraded guava versions from v18.0 to v25.1. Verified all… … tests work as expected except for 1. NIFI-5562 - Upgraded to Guava 26.0-jre which fixes a cache eviction bug

[GitHub] nifi pull request #2976: NIFI-4426 - Replaced Java7 jBCrypt implementation w...

2018-08-30 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2976 NIFI-4426 - Replaced Java7 jBCrypt implementation which was made for … …Java7 backwards compatibility. It now uses a normal maven import to provide jBCrypt. Thank you for submitting

[GitHub] nifi issue #2972: NIFI-5558 Fixed unit test to avoid contamination from Syst...

2018-08-29 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2972 ./nifi-framework-cluster mvn clean test -Dtest=PopularVoteFlowElectionFactoryBeanTest [INFO] Results: [INFO] [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[GitHub] nifi pull request #2919: NIFI-5400 - Changed the hostname verifier from the ...

2018-07-27 Thread thenatog
Github user thenatog commented on a diff in the pull request: https://github.com/apache/nifi/pull/2919#discussion_r205847049 --- Diff: nifi-toolkit/nifi-toolkit-admin/src/main/groovy/org/apache/nifi/toolkit/admin/client/NiFiClientFactory.groovy --- @@ -17,38 +17,19

[GitHub] nifi pull request #2919: NIFI-5400 - Changed the hostname verifier from the ...

2018-07-27 Thread thenatog
Github user thenatog commented on a diff in the pull request: https://github.com/apache/nifi/pull/2919#discussion_r205846603 --- Diff: nifi-toolkit/nifi-toolkit-admin/src/main/groovy/org/apache/nifi/toolkit/admin/client/NiFiClientFactory.groovy --- @@ -17,38 +17,19

[GitHub] nifi pull request #2919: NIFI-5400 - Changed the hostname verifier from the ...

2018-07-26 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2919 NIFI-5400 - Changed the hostname verifier from the custom NiFi verifi… …er to the Apache http-client DefaultHostnameVerifier Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi pull request #2759: NIFI-5258 - Changed addHeader to setHeader which st...

2018-07-11 Thread thenatog
Github user thenatog closed the pull request at: https://github.com/apache/nifi/pull/2759 ---

[GitHub] nifi pull request #2840: NIFI-5374 - Suppress stacktrace being returned to r...

2018-07-03 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2840 NIFI-5374 - Suppress stacktrace being returned to remote client when using NiFi REST API Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #2812: NIFI-5258 - Changed the way servlets are created fo...

2018-06-25 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2812 NIFI-5258 - Changed the way servlets are created for the documentation webapp Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution

[GitHub] nifi pull request #2791: NIFI-5258 - Changed addHeader to setHeader which st...

2018-06-13 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2791 NIFI-5258 - Changed addHeader to setHeader which stops X-Frame-Option… …s being added twice to responses. Added unit test. Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #2761: NIFI-5209 Removed secure hash functionality from ConfigEnc...

2018-06-05 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2761 Looks fine to me after looking at https://issues.apache.org/jira/browse/NIFI-4942, executed encrypting a properties file which worked and attempted to use the -z param which no longer works. Had

[GitHub] nifi issue #2761: NIFI-5209 Removed secure hash functionality from ConfigEnc...

2018-06-05 Thread thenatog
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2761 Reviewing.. ---

[GitHub] nifi pull request #2759: NIFI-5258 - Changed addHeader to setHeader which st...

2018-06-04 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2759 NIFI-5258 - Changed addHeader to setHeader which stops X-Frame-Option… …s being added twice to responses. Changed the way docs webapp is created to allow adding the X-Frame-Options header

[GitHub] nifi pull request #2684: NIFI-5161 - Escape special characters in keystore a...

2018-05-07 Thread thenatog
GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/2684 NIFI-5161 - Escape special characters in keystore alias for toolkit Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you