Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103650361
--- Diff:
nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java
---
@@ -0,0 +1,330
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103649158
--- Diff:
nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java
---
@@ -0,0 +1,216
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103648209
--- Diff:
nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/event/LumberjackEvent.java
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103648185
--- Diff:
nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/ListenLumberjack.java
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103647459
--- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/pom.xml
---
@@ -0,0 +1,76 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103645596
--- Diff:
nifi-nar-bundles/nifi-beats-bundle/nifi-beats-nar/src/main/resources/META-INF/LICENSE
---
@@ -0,0 +1,233
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103599675
--- Diff:
nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java
---
@@ -0,0 +1,216
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103599499
--- Diff:
nifi-nar-bundles/nifi-beats-bundle/nifi-beats-nar/src/main/resources/META-INF/LICENSE
---
@@ -0,0 +1,233
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103599319
--- Diff:
nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/ListenLumberjack.java
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1418#discussion_r103599241
--- Diff:
nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java
---
@@ -0,0 +1,330
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1541
also note that the easier way of setting up an IRC for testing is to spin
up miniircd, which works like a charm for basic testing
---
If your project is set up for it, you can reply to this email
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1541
this PR still not ready to review, however given this is the first time I
am putting together a ControllerService I would appreciate some early feedback.
As you can see, design
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1541
NIFI-329 - Introduce IRC Client Services and ConsumeIRC processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1528
Thanks for the heads up @pvillard31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1528
@WilliamNouet this looks like a duplicated PR from the other one
introducing Morphlines? If so, mind to close it?
---
If your project is set up for it, you can reply to this email and have your
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102860737
--- Diff:
nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java
---
@@ -0,0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102860592
--- Diff:
nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java
---
@@ -0,0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102856855
--- Diff:
nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java
---
@@ -0,0
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1529
@WilliamNouet - thank you for the contribution. Had a quick look and added
some comments. Other will probably want to have a look as well.
---
If your project is set up for it, you can reply
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102855578
--- Diff:
nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/pom.xml ---
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102854353
--- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/pom.xml ---
@@ -40,7 +40,21 @@
org.apache.nifi
nifi-utils
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102854253
--- Diff:
nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-nar/pom.xml ---
@@ -0,0 +1,41 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102854106
--- Diff: nifi-nar-bundles/nifi-morphlines-bundle/pom.xml ---
@@ -0,0 +1,39 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://w
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1529#discussion_r102853739
--- Diff:
nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/pom.xml ---
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1529
@WilliamNouet to squash commit just checkout your branch and run:
`git rebase -i`
and follow the squash process as very well exemplified here:
http://gitready.com/advanced
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1526
@jvwing @gene-telligent - would you mind having a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1526
NIFI-3514 - Ensures ListGCPBucket triggers serially and forbids inputs
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/379
@pvillard31 that connection strategy is agnostic to the underlying
filesystem supporting alluxio. What it does is to allow a hadoop compatible
application to access alluxio without further coding
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/379
And by last comment I naturally refer to use a customised core-site.xml
that includes:
```
fs.alluxio.impl
alluxio.hadoop.FileSystem
The Alluxio FileSystem (Hadoop 1.x
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/379
@pvillard31 not sure if it is the case but have you by any chance tried to
use the Hadoop alluxio interfaces with puthdfs and co instead of a new
processor?
e.g
https
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1519
@mcgilman any chance of having a look on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1240
@bbende @markap14 or @joewitt
I suspect this PR and its 0.x counterpart will benefit from having one of
you reviewing it?
---
If your project is set up for it, you can reply to this email
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1378
@pvillard31 :rofl: yeah... wrong PR but glad you got it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1395
@nickcarenza - welcome. We all have been in that very same boat once.
:smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/349
Thabk Kay, would it be possible to close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan closed the pull request at:
https://github.com/apache/nifi/pull/1521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
To further my above comments, it seems that shortly after the original PR,
AWS released an IoT SDK for Java under ASL2 license.
I vote we close this PR and restart work using AWS' own SDK
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
https://github.com/aws/aws-iot-device-sdk-java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
@JPercivall @joewitt
The original PR seems to contain significant sections of code that are
close to an old version of the following code:
https://github.com/inventit/mqtt
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1331
@apsaltis - glad comments were helpful.
New PR or not, the work is truly great and I can confess that with the
exception of Azure components I will very likely be using it the outcome
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
**JPercivall**
Currently the only tests are integration tests that rely on an AWS
instance. I would like to see more true unit tests. For inspiration, check out
the Publish/Consume MQTT unit
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
**JPercivall**
A couple places have weird comments like "// @TRACE 252=connect to host {0}
port {1} timeout {2}". Is this a convention I'm not aware of or left over from
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916245
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java
---
@@ -0,0 +1,114
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916202
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java
---
@@ -0,0 +1,114
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916129
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoTShadow.java
---
@@ -0,0 +1,107
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916101
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/IoTMessage.java
---
@@ -0,0 +1,44
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916076
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
**JPercivall**
The Get/PutAWSIoT processors read and overwrite mqttClient many times
without a read/write lock, this can lead to problems in multi-threaded
scenarios. For example, the both
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916052
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916039
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101916002
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/MqttWebSocketAsyncClient.java
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
**JPercivall**
A bit nit picky and I may be alone here, but I find putting "if" statements
and their content on the same line a bit hard to read when trying to read
someone e
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
**JPercivall**
I actually already committed general MQTT processors [1] and they have some
good "best practices" with regards to publishing/consuming messages and MQTT I
think wou
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
JPercivall
Does AWS IoT support communicating over SSL with MQTT or shadows? If so,
that option should be added.
---
If your project is set up for it, you can reply to this email and have your
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101915884
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1521#discussion_r101915841
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1521
@KayLerch - Thank you for the contribution, I squashed your commit but left
attribution untouched so credit is due to who deserves it.
@JPercivall this is not ready to review. For now the PR
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1521
NIFI-1767 - Added 1st iteration of IOT-Processors for reading and wriâ¦
â¦ting AWS IOT shadow and MQTT topics
This closes: #349
Thank you for submitting a contribution to Apache
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/349
@joewitt - I am happy to adopt the stalled PR and address @JPercivall 's
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1332
@ijokarumawak - This PR needs rebasing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/399
@slachterman - thank you for the handy link
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1395
@nickcarenza thank you for the contribution. May I ask you to squash the
commit as requested by the PR template?
` Is your initial contribution a single, squashed commit?`
At least
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1331
@apsaltis - loved the idea behind this contribution - I'm also very much in
favor of fitting MiNiFi with existing systems - and perhaps that's the reason
for my first question
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1148
@mauriziocolleluori thank you for the contribution.
any intent on addressing @pvillard31 's comment? While a positive answer is
more than welcome, a negative answer is also welcome... all we
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1387#discussion_r101913412
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/CreateHadoopSequenceFile.java
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1335
@ijokarumawak merged. However I forgot to add reference to the PR in the
commit message. Would you mind closing it manually ?
I thank you in advance
---
If your project is set up
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1290
@klinvill
Is this PR still needed or was it identified as a data quality issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1016
@brianburnett
I suspect the reason for that is because you are trying to cherry-pick from
the branch you already have a commit.
Note how I suggested you to circle around
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1016
No no. Cherry pick your commit number.
You will likely to fix conflicts in the process but git will flag those
files with conflict so once you fix it should be ok at the end
---
If your
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1016
Try
git checkout master -b nifi-2724v2
git cherry-pick your commit hash
git push - f origin nifi-2724
This will create a temporary branch
Allow you to copy a commit from
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1016
Try
git checkout master -b nifi-2724v2
git cherry-pick
git push origin nifi-2724
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1016
That was a merge, not a rebase :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1335
@ijokarumawak my bad. I was just running a extra set of compilations and I
noticed that under certain conditions there seems to be a race condition
affecting
```
Tests run: 12, Failures
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1335
LGTM merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1335
@ijokarumawak reviewing it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1326
@patricker merge after build, reviewed code and ran against an exchange
server. Seems to be working fine.
thank you for the contribution!
---
If your project is set up for it, you can
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1505
@apiri hopefully this time it looks a bit better... yes... it is a fork of
a fork. :crying_cat_face:
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1481
@mosermw ohhh. wasn't aware of it. thanks for sharing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1481
@markap14 I suspect the reason is @mosermw added the closure after the
signature and closure should come above sign-off-by?
---
If your project is set up for it, you can reply to this email
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1326
you did a merge and that dragged dozens of committed commits into this PR.
Instead you may want to do:
```
git checkout master -b NIFI-2779v2
git cherry-pick
git push
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1383
@pvillard31 @bbende LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1328
@JPercivall - needs rebasing again. :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/709
@simonellistonball ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/913
@jskora closed it.
Whenever this happens you can simply push an empty commit to git with the
fixed reference to the PR
---
If your project is set up for it, you can reply to this email
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/689
@markap14 @JPercivall
Given we getting well into 1.2, should this PR still go ahead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/453
@eorgad , this PR is nearly 1 year old do you still plan to address some of
the feedback? Would you mind closing the PR for now?
---
If your project is set up for it, you can reply to this email
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/972
@brosander is the PR still wanted? If yes, mind rebasing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1326
@patricker can you please rebase as changes to master are causing conflicts
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1505
Epic. Will adjust
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1370
@pvillard31 LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1474
@alopresto - the missing amendments have been uploaded and hopefully also
addressed the comments made earlier
---
If your project is set up for it, you can reply to this email and have your
reply
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1474#discussion_r101007689
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutFTP.java
---
@@ -0,0 +1,90
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1474#discussion_r101007664
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutFTP.java
---
@@ -0,0 +1,90
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1474#discussion_r101007316
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -230,6 +230,12 @@ language governing permissions and limitations
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1505
NIFI-2565 - Add Elastic copyright to notice due to the use of grok patterns
during test
since the patterns used during testing were originally defined here
https://github.com/logstash
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1474
PR still not complete Andy. My bad
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1480
@pvillard31 - after a few hundred builds and options build seems to be
having as expected:
https://travis-ci.org/trixpan/nifi/builds/200568234
when environment is set to en_US
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1480
@pvillard31 - this seems to be working now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1480
by the way, good catch, I had faced this issue before but totally forgot
about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1480
seems great. will do it and force push soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
201 - 300 of 658 matches
Mail list logo
