[GitHub] [nifi] MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors

2020-03-22 Thread GitBox
MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors URL: https://github.com/apache/nifi/pull/4104#issuecomment-602196249 > but instead are due to actual 'test wont work on windows' issues. That's pretty much what I was getting at.

[GitHub] [nifi] MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors

2020-03-22 Thread GitBox
MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors URL: https://github.com/apache/nifi/pull/4104#issuecomment-602191215 @joewitt ok, but we may need to reevaluate some of the tests because some of them have had timing issues on Windows

[GitHub] [nifi] MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors

2020-03-22 Thread GitBox
MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors URL: https://github.com/apache/nifi/pull/4104#issuecomment-602181635 I'll try to find some time today to play around with the APIs to see what validation is even possible. The first

[GitHub] [nifi] MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors

2020-03-21 Thread GitBox
MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors URL: https://github.com/apache/nifi/pull/4104#issuecomment-602097123 @markap14 could you take a look at the precision part and give me your opinion?

[GitHub] [nifi] MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors

2020-03-17 Thread GitBox
MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors URL: https://github.com/apache/nifi/pull/4104#issuecomment-600106854 As a rule of thumb, if the Linux build passes we can merge. Will try to find some time to review.

[GitHub] [nifi] MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors

2020-03-15 Thread GitBox
MikeThomsen commented on issue #4104: NIFI-7159 - Add support for some data types in various processors URL: https://github.com/apache/nifi/pull/4104#issuecomment-599209694 @Xeinn there's a merge conflict now. Instructions follow if you're newish to git. Otherwise ignore. To