[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-03-09 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-1063290645 @joewitt addressed your request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-03-04 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-1059125322 @exceptionfactory @mattyb149 any chance we could close this out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-03-02 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-1057062266 @exceptionfactory @ottobackwards @mattyb149 should be good to go now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-03-01 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-1055628577 @mattyb149 > I had to enable the rest of the flow so the cache values would be populated by the PutDistributedMapCache processor. Is that intended? If so the docs

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-03-01 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-1055589508 Good feedback. Will incorporate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-03-01 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-1055544885 @mattyb149 @exceptionfactory @ottobackwards I think we're good new. See the attacked template and steps to setup Cassandra in docker to quickly test. -- This is an

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-03-01 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-1055541043 [DeduplicateRecords_TestWithCassandraDMC.xml.txt](https://github.com/apache/nifi/files/8162499/DeduplicateRecords_TestWithCassandraDMC.xml.txt) Here is a test flow.

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2022-02-28 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-105446 Revisiting this. @ottobackwards @mattyb149 @exceptionfactory going to work through any remaining comments and see if we can close this out this week. -- This is an

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2021-04-22 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-825221203 Thanks @ottobackwards. I'll try to make some time to knock these out tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2021-04-15 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-820737577 I think it is close to being done, but it fell off everyone's radars (including @adamfisher). @ottobackwards you can pick up the review now if @mattyb149 is low on time :-D

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2020-11-23 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-732402943 @mattyb149 thanks for taking a look. I'll try to carve out some time in the evening to address. This is an

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2020-11-03 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-721282868 @adamfisher FYSA This is an automated message from the Apache Git Service. To respond to the message, please