MuazmaZ commented on a change in pull request #4265: URL: https://github.com/apache/nifi/pull/4265#discussion_r431512390
########## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java ########## @@ -85,6 +86,20 @@ .sensitive(true) .build(); + public static final PropertyDescriptor ENDPOINT_SUFFIX = new PropertyDescriptor.Builder() + .name("storage-endpoint-suffix") + .displayName("Common Storage Account Endpoint Suffix") + .description( + "Storage accounts in public Azure always use a common FQDN suffix. " + + "Override this endpoint suffix with a different suffix in certain circumsances (like Azure Stack or non-public Azure regions). " + + "The preferred way is to configure them through a controller service specified in the Storage Credentials property. " + + "The controller service can provide a common/shared configuration for multiple/all Azure processors. Furthermore, the credentials " + + "can also be looked up dynamically with the 'Lookup' version of the service.") + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) Review comment: I would suggest Option 1 as either, not both. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org