[GitHub] [nifi] NissimShiman commented on pull request #6254: NIFI-10287 ExecuteScript - Allow python scripts to use external modules

2022-11-02 Thread GitBox
NissimShiman commented on PR #6254: URL: https://github.com/apache/nifi/pull/6254#issuecomment-1301506031 Thank you @mattyb149 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] NissimShiman commented on pull request #6254: NIFI-10287 ExecuteScript - Allow python scripts to use external modules

2022-10-20 Thread GitBox
NissimShiman commented on PR #6254: URL: https://github.com/apache/nifi/pull/6254#issuecomment-1285633551 @mattyb149 I was wondering if you could take a look at this again. The previous issue you (and another reviewer) mentioned has been resolved. -- This is an automated message from

[GitHub] [nifi] NissimShiman commented on pull request #6254: NIFI-10287 ExecuteScript - Allow python scripts to use external modules

2022-10-05 Thread GitBox
NissimShiman commented on PR #6254: URL: https://github.com/apache/nifi/pull/6254#issuecomment-1265652117 @mattyb149 @exceptionfactory @MikeThomsen I removed the unit test that was concerning so I think we are good. The unit test for the main use case of the ticket remains. Please let

[GitHub] [nifi] NissimShiman commented on pull request #6254: NIFI-10287 ExecuteScript - Allow python scripts to use external modules

2022-09-12 Thread GitBox
NissimShiman commented on PR #6254: URL: https://github.com/apache/nifi/pull/6254#issuecomment-1244244831 Thank you very much @dan-s1 for the review and for volunteering the unit test for the use case that was missed! Squashed commits after approval to make it easier for additional