[GitHub] [nifi] alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function

2019-10-18 Thread GitBox
alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function URL: https://github.com/apache/nifi/pull/3825#issuecomment-544014001 I do think a custom delimiter string would be useful, but introducing one required and two (different) optional parameters gets tricky. I

[GitHub] [nifi] alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function

2019-10-18 Thread GitBox
alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function URL: https://github.com/apache/nifi/pull/3825#issuecomment-543930913 I noticed that in the unit test, only attributes containing string values are tested. I am using a literal string in my smoke test. That may

[GitHub] [nifi] alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function

2019-10-18 Thread GitBox
alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function URL: https://github.com/apache/nifi/pull/3825#issuecomment-543914202 I also pushed the test fix to [4376d86](https://github.com/alopresto/nifi/commit/4376d86f6d6121976f918291a80d625f99aea2e7). Apparently my

[GitHub] [nifi] alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function

2019-10-18 Thread GitBox
alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function URL: https://github.com/apache/nifi/pull/3825#issuecomment-543913272 I did a local build and tested this and I am experiencing odd behavior. While the code complete does suggest `repeat` and has the correct

[GitHub] [nifi] alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function

2019-10-17 Thread GitBox
alopresto commented on issue #3825: NIFI-6782: Added repeat() String EL function URL: https://github.com/apache/nifi/pull/3825#issuecomment-543331278 Matt, this looks awesome. Thanks for the quick turnaround. As soon as I finish PR 3821, I will review this.