dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1591818470
@exceptionfactory I added the new modules as you requested. Please let me
know if these are what you envisioned.
--
This is an automated message from the Apache Git Service.
To respond to
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1584941126
@exceptionfactory I found that I had to cut and paste files
1. org/apache/nifi/schema/inference/CachedSchemaAccessStrategy.java
2.
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1584614010
@exceptionfactory In order to do this I do need many of the dependencies
that are already in `nifi-schema-registry-service-api` as well as classes that
are in that module e.g.
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1579479353
@exceptionfactory Please let me know if there is anything else. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1575625659
@exceptionfactory Can you please restart the Windows Zulu JDK 11 FR build?
It timed out. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1574131993
@exceptionfactory I believe I made all the requested changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1570599292
@exceptionfactory ļ‘¨Finally that Windows build succeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1570338648
@exceptionfactory Can you please restart the Windows Zulu JDK 11 FR ? It had
timed out yesterday. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1568833205
@exceptionfactory Seems like the failure in the build was unrelated to the
code I checked in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1567114781
@exceptionfactory Just checking if there is anything else I need to do for
this PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1555017392
@exceptionfactory I believe I covered all the points your brought up. Please
let me know how this looks and whether there is anything else to change.
Can I mark the conversations resolved
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1528095567
@exceptionfactory I simplified the unit tests to avoid any locale issues
(much like org.apache.nifi.csv.TestCSVSchemaInference). I also added unit tests
to highlight the difference between
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1527776319
@exceptionfactory I was able to find the discrepancy and it is not what I
thought. It is actually dependent on the java.util.Locale and not the operating
system. In order to use the
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1526611194
@exceptionfactory The only thing I can think of right now is perhaps there
are differences between how the Excel document is interpreted on a native
Windows environment and on Linux
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1526550261
@exceptionfactory So my changes did improve things though now on the Windows
box it is failing due to it interpreting a number as a string. What would you
like me to do for this?
--
This
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1526041161
@exceptionfactory Are the locales where these CI builds English speaking? I
suspect if not, then PM is not displayed in the Excel spreadsheet as it would
be in an English speaking locale.
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1524048362
> @exceptionfactory @dan-s1 This is a really interesting PR. I've had a
number of clients that would benefit from this sort of capability. My one big
question/concern is whether or not this
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1522486122
@exceptionfactory When running mvn -v I have
```
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
Maven home: /opt/apache-maven-3.9.0
Java version: 11.0.18,
dan-s1 commented on PR #7194:
URL: https://github.com/apache/nifi/pull/7194#issuecomment-1521942524
@MikeThomsen @exceptionfactory The test failures I see are
> Error: Failures:
> Error:TestExcelSchemaInference.testInferenceIncludesAllRecords:62
expected: but
was:
>
19 matches
Mail list logo
