[GitHub] [nifi] exceptionfactory commented on pull request #4972: NIFI-7912 - Added a Denial of Service filter wrapper called NiFiDoSFi…

2021-04-07 Thread GitBox
exceptionfactory commented on pull request #4972: URL: https://github.com/apache/nifi/pull/4972#issuecomment-814876578 > @thenatog Thanks for the review changes! > @exceptionfactory I have no more comments, +1 from my side too. Thanks for the confirmation @turcsanyip! Merging.

[GitHub] [nifi] exceptionfactory commented on pull request #4972: NIFI-7912 - Added a Denial of Service filter wrapper called NiFiDoSFi…

2021-04-06 Thread GitBox
exceptionfactory commented on pull request #4972: URL: https://github.com/apache/nifi/pull/4972#issuecomment-814520389 Thanks for making the documentation updates @thenatog! With these changes, I am +1. Do you have any additional feedback @turcsanyip? -- This is an automated message

[GitHub] [nifi] exceptionfactory commented on pull request #4972: NIFI-7912 - Added a Denial of Service filter wrapper called NiFiDoSFi…

2021-04-06 Thread GitBox
exceptionfactory commented on pull request #4972: URL: https://github.com/apache/nifi/pull/4972#issuecomment-814106145 > I agree that the IP whitelisting is more representative of how the DoS should work rather than excluding the S2S paths. Testing this out it seems like the whitelist is