[GitHub] [nifi] markap14 commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-14 Thread GitBox
markap14 commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-841386401 Thanks @simonbence ! All looks good now. Fixed one checkstyle violation but all was good otherwise. +1 merged to main! -- This is an automated message from the Apache Git

[GitHub] [nifi] markap14 commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-13 Thread GitBox
markap14 commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-840846222 One last thing that I think is necessary: please make sure that the admin guide is updated to describe the new properties. -- This is an automated message from the Apache Git

[GitHub] [nifi] markap14 commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-13 Thread GitBox
markap14 commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-840845848 https://issues.apache.org/jira/secure/attachment/13025442/0001-NIFI-8519-Support-RequiresInstanceClassLoading-annot.patch is the patch that I attached. -- This is an automated

[GitHub] [nifi] markap14 commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-13 Thread GitBox
markap14 commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-840691381 There is no write up. Just a general observation: it doesn't really make sense IMO to allow for the extensions in nifi to live in either local filesystem or HDFS. What does make

[GitHub] [nifi] markap14 commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-12 Thread GitBox
markap14 commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-839940334 @ottobackwards not sure VFS would provide what we need here. Not sure how it deals with all of the authentication etc. But most importantly, it doesn't really provide us the

[GitHub] [nifi] markap14 commented on pull request #5059: NIFI-8519 Adding HDFS support for NAR autoload

2021-05-11 Thread GitBox
markap14 commented on pull request #5059: URL: https://github.com/apache/nifi/pull/5059#issuecomment-838659499 Thanks for the contribution @simonbence! Looking through this i think ideas are sound. However, this is updating the `nifi-api` module, and once it's been released it's