markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875847911
Java 8 contrib-check passed as well. Good to go unless you have any
additional comments @mattyb149
--
This is an automated message from the Apache Git Service.
To respond to
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875816755
Java 11 contrib-check succeeded, so I pushed update. Running Java 8
contrib-check now.
--
This is an automated message from the Apache Git Service.
To respond to the message,
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875772050
Rebased to main and running contrib-check now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875631065
Clarifying the outcome of the latest push. I followed your steps to
reproduce, and the new PG properties maintained their values, as expected.
1. Starting from a blank
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875188312
@mattyb149 I force pushed an update. (The force was to overwrite the "wip"
which was not necessary.) I also discovered a related issue in
StandardFlowSynchronizer.java which I
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875130866
Yeah, that WIP commit was simply a placeholder after I took 5 minutes to
look at it from work, and commit so I could continue after a fresh pull at
home. Just reading your
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875080985
Ok, good catch. I guess I never moved the PG. That's odd behavior to say the
least. I don't know why simply moving the PG would cause it to revert. I'll
look into it.
Any
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-875036011
Awesome. Thanks @mattyb149
And, if you find a case where properties are inherited from nifi.properties
(or anywhere other than the PG's immediate parent), please let me know.
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-874937062
@mattyb149 Just wanted to clarify if your question was based on observed
behavior (which I can't reproduce), or if it was a general question based on
how you believed it would
markobean commented on pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#issuecomment-870773704
When creating a new process group, the properties will inherit from its
immediate parent. The backpressure defaults from nifi.properties should only be
used when at the root
10 matches
Mail list logo
