[GitHub] [nifi] mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types

2019-09-13 Thread GitBox
mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types URL: https://github.com/apache/nifi/pull/3684#issuecomment-531230087 Thanks again for the review and suggestions to improve the code! Based on your +1 and my own testing, merging to

[GitHub] [nifi] mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types

2019-09-09 Thread GitBox
mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types URL: https://github.com/apache/nifi/pull/3684#issuecomment-529601617 @tpalfy Are you available to review the latest changes?

[GitHub] [nifi] mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types

2019-09-03 Thread GitBox
mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types URL: https://github.com/apache/nifi/pull/3684#issuecomment-527621717 Thanks for the review! I incorporated (and appreciate) your comments

[GitHub] [nifi] mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types

2019-08-30 Thread GitBox
mattyb149 commented on issue #3684: NIFI-6295: Refactored NiFiRecordSerDe to handle nested complex types URL: https://github.com/apache/nifi/pull/3684#issuecomment-526752138 @gideonkorir I started with your #3509 commit and did the refactor (a la JsonSerDe) as we discussed, plus tested