[GitHub] [nifi] mattyb149 commented on pull request #5192: NIFI-8195: add default connection settings to process group configura…

2021-07-07 Thread GitBox
mattyb149 commented on pull request #5192: URL: https://github.com/apache/nifi/pull/5192#issuecomment-875956406 +1 LGTM, ran a few different scenarios and verified the results were as expected. Thanks for the feature! Merging to main -- This is an automated message from the Apache Git

[GitHub] [nifi] mattyb149 commented on pull request #5192: NIFI-8195: add default connection settings to process group configura…

2021-07-07 Thread GitBox
mattyb149 commented on pull request #5192: URL: https://github.com/apache/nifi/pull/5192#issuecomment-875739763 Did you rebase your branch against main? That error was fixed via NIFI-8757 (#5198) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nifi] mattyb149 commented on pull request #5192: NIFI-8195: add default connection settings to process group configura…

2021-07-06 Thread GitBox
mattyb149 commented on pull request #5192: URL: https://github.com/apache/nifi/pull/5192#issuecomment-875101003 Not sure if your latest WIP commit is the right approach, check my latest comment on StandardProcessGroupDAO -- This is an automated message from the Apache Git Service. To

[GitHub] [nifi] mattyb149 commented on pull request #5192: NIFI-8195: add default connection settings to process group configura…

2021-07-06 Thread GitBox
mattyb149 commented on pull request #5192: URL: https://github.com/apache/nifi/pull/5192#issuecomment-875066826 I was able to reproduce with the following: 1) Starting from a blank canvas/flow, create a new PG at the root level called 'test1' 2) Right-click on the PG and change

[GitHub] [nifi] mattyb149 commented on pull request #5192: NIFI-8195: add default connection settings to process group configura…

2021-07-06 Thread GitBox
mattyb149 commented on pull request #5192: URL: https://github.com/apache/nifi/pull/5192#issuecomment-875028755 I'm doing a final build/review/test before merging, hopefully merged in an hour or so -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nifi] mattyb149 commented on pull request #5192: NIFI-8195: add default connection settings to process group configura…

2021-06-29 Thread GitBox
mattyb149 commented on pull request #5192: URL: https://github.com/apache/nifi/pull/5192#issuecomment-870759144 Should a child process group inherit from its immediate parent? Looks like any PG will be created with the nifi.properties defaults rather than its immediate parent. -- This