[GitHub] [nifi] mattyb149 commented on pull request #5366: NIFI-9194: Upsert for Oracle12+

2021-11-08 Thread GitBox
mattyb149 commented on pull request #5366: URL: https://github.com/apache/nifi/pull/5366#issuecomment-963737436 +1 LGTM, tried with a live Oracle 12 instance, verified the UPSERT capability is working as expected. Thanks for the new feature! Merging to main -- This is an automated

[GitHub] [nifi] mattyb149 commented on pull request #5366: NIFI-9194: Upsert for Oracle12+

2021-10-29 Thread GitBox
mattyb149 commented on pull request #5366: URL: https://github.com/apache/nifi/pull/5366#issuecomment-954804033 There are lots of tab characters in here, the Github Action builds will fail for this reason. Please replace them with spaces and run your local Maven build from the

[GitHub] [nifi] mattyb149 commented on pull request #5366: NIFI-9194: Upsert for Oracle12+

2021-10-28 Thread GitBox
mattyb149 commented on pull request #5366: URL: https://github.com/apache/nifi/pull/5366#issuecomment-954239270 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific