scottyaslan commented on a change in pull request #5069:
URL: https://github.com/apache/nifi/pull/5069#discussion_r632001034
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-context-menu.js
##########
@@ -844,9 +853,21 @@
{id: 'show-source-menu-item', condition: isConnection, menuItem:
{clazz: 'fa fa-long-arrow-left', text: 'Go to source', action: 'showSource'}},
{id: 'show-destination-menu-item', condition: isConnection, menuItem:
{clazz: 'fa fa-long-arrow-right', text: 'Go to destination', action:
'showDestination'}},
{separator: true},
- {id: 'align-menu-item', groupMenuItem: {clazz: 'fa', text: 'Align'},
menuItems: [
- {id: 'align-horizontal-menu-item', condition: canAlign, menuItem:
{ clazz: 'fa fa-align-center fa-rotate-90', text: 'Horizontally', action:
'alignHorizontal'}},
- {id: 'align-vertical-menu-item', condition: canAlign, menuItem:
{clazz: 'fa fa-align-center', text: 'Vertically', action: 'alignVertical'}}
+ {id: 'align-menu-item', groupMenuItem: {clazz: 'carbon
carbon-align--horizontal-left', text: 'Align'}, menuItems: [
Review comment:
All other icons in the context menu have a color of #004849. Please
update these icons to also have this color applied.
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml
##########
@@ -246,6 +246,11 @@
<include>moment/README.md</include>
<include>moment/LICENSE</include>
+ <!-- carbon icons -->
+
<include>@carbon/icons/svg/**/*</include>
Review comment:
It would be great if we did not need to add yet another dependency here.
Maybe we can use one of the available icons from font awesome or the custom
flowfont created for this project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
