[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-28 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-525852030 Talked to @markap14 and now you can create new parameters with null value and you can update a parameter value to null.

[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-28 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-525851670 Talked to @mcgilman and we need to trim new parameter names before we request to create. This is an

[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-27 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-525431965 > I wonder if it makes sense to add a `white-space: pre` style to the parameter name cells in the table. Without it, multiple spaces just render as a single one so it

[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-26 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-525013059 > > Maybe we can just document that this is the case??? Otherwise the only solution I could come up with would be to update the parameter context with all the deletes

[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-26 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-524995557 > @scottyaslan @mcgilman: If you add a parameter and Apply it to the param context. Then you come back at some point in the future to delete that parameter and add it

[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-26 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-524950736 @rfellows nice catch I have updated this PR to enable the Apply button when the checkbox is checked.

[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-26 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-524949047 @markap14 nice catch. I have updated this PR to fix the issue with viewing parameters for a PG. This

[GitHub] [nifi] scottyaslan commented on issue #3606: [WIP] Nifi 6282

2019-08-22 Thread GitBox
scottyaslan commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-523956904 > I also find that when I apply updates to the Parameter Context, the dialog on the right-hand side shows which components are affected, rolled up by group. If I