[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

2022-02-21 Thread GitBox
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1047209429 @exceptionfactory It looks good to me now. I also tested it a bit with Snowflake and it works properly. There are two minor typos in the description of `Snowflake URL`

[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

2022-02-15 Thread GitBox
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1039276217 @tpalfy Please do not forget to add LICENCE / NOTICE files in the nar bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

2022-02-14 Thread GitBox
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1039276217 @tpalfy Please do not forget to add LICENCE / NOTICE files in the nar bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

2022-01-25 Thread GitBox
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021056412 @tpalfy @exceptionfactory Regarding nar/jar dependencies, I believe the following should work: - declare `nifi-dbcp-service-nar` as the parent nar of the new

[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

2022-01-25 Thread GitBox
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021056412 @tpalfy @exceptionfactory Regarding nar/jar dependencies, I believe the following should work: - declare `nifi-dbcp-service-nar` as the parent nar of the new