[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-05-03 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r624923671 ## File path: libminifi/src/FlowController.cpp ## @@ -302,6 +302,10 @@ void FlowController::load(const std::shared_ptr , bool

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-26 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620064134 ## File path: libminifi/include/core/Processor.h ## @@ -251,6 +252,10 @@ class Processor : public Connectable, public

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-12 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r611703112 ## File path: extensions/standard-processors/processors/ExecuteProcess.h ## @@ -51,7 +51,7 @@ namespace processors { #ifndef WIN32 //

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-08 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r609730581 ## File path: extensions/standard-processors/processors/ExecuteProcess.h ## @@ -51,7 +51,7 @@ namespace processors { #ifndef WIN32 //

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-08 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r609663815 ## File path: extensions/standard-processors/processors/ExecuteProcess.h ## @@ -51,7 +51,7 @@ namespace processors { #ifndef WIN32 //

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-08 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r609605401 ## File path: .github/workflows/ci.yml ## @@ -218,7 +218,7 @@ jobs: sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-08 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r609378101 ## File path: libminifi/src/core/Processor.cpp ## @@ -386,6 +379,39 @@ std::shared_ptr Processor::pickIncomingConnection() { return

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-07 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r608642381 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -71,7 +71,7 @@ enum class Mode { SINGLE, MULTIPLE, UNDEFINED

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-07 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r608471765 ## File path: libminifi/include/core/Annotation.h ## @@ -0,0 +1,77 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under