[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1435: MINIFICPP-1959 - Avoid dangling content references when using VolatileFlowFileRepository

2022-11-04 Thread GitBox
adam-markovics commented on code in PR #1435: URL: https://github.com/apache/nifi-minifi-cpp/pull/1435#discussion_r1013850774 ## libminifi/test/unit/ProcessSessionTests.cpp: ## @@ -138,3 +144,44 @@ TEST_CASE("ProcessSession::read can read zero length flowfiles without crash",

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1435: MINIFICPP-1959 - Avoid dangling content references when using VolatileFlowFileRepository

2022-11-02 Thread GitBox
adam-markovics commented on code in PR #1435: URL: https://github.com/apache/nifi-minifi-cpp/pull/1435#discussion_r1011863921 ## libminifi/src/core/ProcessSession.cpp: ## @@ -958,54 +958,72 @@ void ProcessSession::persistFlowFilesBeforeTransfer( auto flowFileRepo =