[GitHub] [nifi-minifi-cpp] bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues

2019-09-05 Thread GitBox
bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues URL: https://github.com/apache/nifi-minifi-cpp/pull/638#issuecomment-528430959 > @bakaid is this good to merge? is the parallel build issue solved here? I suspect that it was but wanted to confirm first. @phrocker

[GitHub] [nifi-minifi-cpp] bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues

2019-08-30 Thread GitBox
bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues URL: https://github.com/apache/nifi-minifi-cpp/pull/638#issuecomment-526619532 @phrocker I would prefer the whole civetweb to be moved to an ExternalProject - I planned to do that with the review of passing our shipped

[GitHub] [nifi-minifi-cpp] bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues

2019-08-30 Thread GitBox
bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues URL: https://github.com/apache/nifi-minifi-cpp/pull/638#issuecomment-526570833 It fixed the parallel builds for me - I would prefer if @jdye64 could try it in his environment, to make sure.

[GitHub] [nifi-minifi-cpp] bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues

2019-08-29 Thread GitBox
bakaid commented on issue #638: MINIFICPP-1018 - Fix linking issues URL: https://github.com/apache/nifi-minifi-cpp/pull/638#issuecomment-526268424 The fix is not completely ready yet, I myself have seen some failures with parallel builds. I think some dependencies are wrong, I plan to look