[GitHub] [nifi-minifi-cpp] bakaid commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-17 Thread GitBox
bakaid commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#issuecomment-575609524 Addressed the new set of review comments, Travis builds seems fixed. Will wait for others to test this.

[GitHub] [nifi-minifi-cpp] bakaid commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-16 Thread GitBox
bakaid commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#issuecomment-575147378 @arpadboda Thanks for the review, addressed your review comments, also updated the MessageCompiler finder cmake magic,

[GitHub] [nifi-minifi-cpp] bakaid commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
bakaid commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#issuecomment-574657086 @arpadboda This code cleans up the minifi main code, MINIFI_HOME determination and Properties a bit. It also adds more