fgerlits commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165532281
########## extensions/aws/CMakeLists.txt: ########## @@ -34,6 +34,9 @@ add_library(minifi-aws SHARED ${SOURCES}) target_link_libraries(minifi-aws PUBLIC ${LIBMINIFI} Threads::Threads) target_wholearchive_library_private(minifi-aws AWS::aws-cpp-sdk-s3) +if(NOT CMAKE_SYSTEM_PROCESSOR MATCHES "(x86)|(X86)") Review Comment: why is this " not (x86 or X86)" instead of "aarch64 or arm64" as originally suggested by @martinzink? if we go the negative route, do we want to add x64 and amd64? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org