[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON

2023-04-13 Thread via GitHub
fgerlits commented on code in PR #1555: URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1165117425 ## extensions/script/CMakeLists.txt: ## Review Comment: I have created Jira https://issues.apache.org/jira/browse/MINIFICPP-2098 as a follow-up. --

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON

2023-04-12 Thread via GitHub
fgerlits commented on code in PR #1555: URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1164462363 ## extensions/script/CMakeLists.txt: ## Review Comment: That's a different issue, because they don't cause a build failure, unlike this one. I