fgerlits commented on pull request #1017:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-954650671
This test passes for me locally after rebasing on top of main, so I think
it's ready for merging.
In order to not increase the running time of the CI job by too
fgerlits commented on pull request #1017:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-879249052
@hunyadi-dev do you want to fix this? I can do it if you don't feel like it.
--
This is an automated message from the Apache Git Service.
To respond to the message,
fgerlits commented on pull request #1017:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-862213301
This still fails after merging #1028 and #1083. The main problem is that
`SingleFileContentHashValidator` reports a hash mismatch on the 2.1 GiB test
file:
```
fgerlits commented on pull request #1017:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-826910263
> The check still shows that we do not handle the file size 2.1 GiB
properly. Merge only once it is fixed.
Right -- #1028 needs to be merged first, and probably
