[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

2020-05-27 Thread GitBox
hunyadi-dev commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r431261205 ## File path: libminifi/include/utils/ValueUtils.h ## @@ -0,0 +1,203 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

2020-05-27 Thread GitBox
hunyadi-dev commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r431260169 ## File path: libminifi/include/utils/ValueUtils.h ## @@ -0,0 +1,203 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

2020-05-27 Thread GitBox
hunyadi-dev commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r431249581 ## File path: libminifi/include/core/PropertyValue.h ## @@ -138,26 +150,28 @@ class PropertyValue : public state::response::ValueNode { */

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

2020-05-27 Thread GitBox
hunyadi-dev commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r431230919 ## File path: libminifi/include/core/Property.h ## @@ -129,41 +133,32 @@ class Property { template void setValue(const T ) { -

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

2020-05-27 Thread GitBox
hunyadi-dev commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r431226910 ## File path: libminifi/include/core/ConfigurableComponent.h ## @@ -216,16 +216,20 @@ bool ConfigurableComponent::getProperty(const std::string

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

2020-05-27 Thread GitBox
hunyadi-dev commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r431026306 ## File path: libminifi/include/core/CachedValueValidator.h ## @@ -0,0 +1,103 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)