[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build

2021-04-26 Thread GitBox
lordgamez commented on a change in pull request #1055: URL: https://github.com/apache/nifi-minifi-cpp/pull/1055#discussion_r620443589 ## File path: docker/DockerBuild.sh ## @@ -112,7 +80,13 @@ while [[ $# -gt 0 ]]; do -c|--cmake-param) IFS='=' read -ra ARR <<< "$2"

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build

2021-04-22 Thread GitBox
lordgamez commented on a change in pull request #1055: URL: https://github.com/apache/nifi-minifi-cpp/pull/1055#discussion_r618363196 ## File path: cmake/DockerConfig.cmake ## @@ -22,7 +22,6 @@ add_custom_target( -u 1000 -g 1000 -v