[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-08 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1016279852 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +70,202 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-07 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1015514169 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +70,202 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-07 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1015514868 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +70,202 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-07 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1015514169 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +70,202 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011973468 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +68,226 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011973043 ## PROCESSORS.md: ## @@ -550,18 +550,18 @@ In the list below, the names of required properties appear in bold. Any other pr ### Description -Runs an

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011972702 ## extensions/standard-processors/processors/ExecuteProcess.h: ## @@ -89,38 +85,35 @@ class ExecuteProcess : public core::Processor { EXTENSIONAPI

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011972454 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +68,226 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011971961 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +68,226 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011971604 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -74,172 +68,226 @@ void ExecuteProcess::initialize() {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011971031 ## extensions/standard-processors/processors/ExecuteProcess.cpp: ## @@ -30,42 +30,36 @@ #include "core/TypedValues.h" #include "utils/gsl.h" -#if

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1414: MINIFICPP-1927 Fix ExecuteProcess command argument issue and refactor

2022-11-02 Thread GitBox
lordgamez commented on code in PR #1414: URL: https://github.com/apache/nifi-minifi-cpp/pull/1414#discussion_r1011877660 ## extensions/standard-processors/tests/resource_apps/EchoParameters.cpp: ## @@ -0,0 +1,34 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)