[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1165408681 ## controller/MiNiFiController.cpp: ## @@ -75,33 +80,60 @@ int main(int argc, char **argv) { secure_context =

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1159633968 ## controller/Controller.cpp: ## @@ -0,0 +1,214 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1152024653 ## controller/Controller.h: ## @@ -18,346 +18,61 @@ #pragma once #include +#include -#include "core/RepositoryFactory.h" -#include

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1151881367 ## controller/Controller.h: ## @@ -18,346 +18,61 @@ #pragma once #include +#include -#include "core/RepositoryFactory.h" -#include

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1151879300 ## controller/MiNiFiController.cpp: ## @@ -15,57 +15,52 @@ * See the License for the specific language governing permissions and * limitations under the

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1150927120 ## controller/Controller.h: ## @@ -18,346 +18,61 @@ #pragma once #include +#include -#include "core/RepositoryFactory.h" -#include

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1150927120 ## controller/Controller.h: ## @@ -18,346 +18,61 @@ #pragma once #include +#include -#include "core/RepositoryFactory.h" -#include

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1150923563 ## controller/tests/ControllerTests.cpp: ## @@ -0,0 +1,484 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1150924463 ## libminifi/src/c2/ControllerSocketMetricsPublisher.cpp: ## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1150922841 ## controller/tests/ControllerTests.cpp: ## @@ -0,0 +1,484 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1150922408 ## controller/MiNiFiController.cpp: ## @@ -15,57 +15,52 @@ * See the License for the specific language governing permissions and * limitations under the

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1150921974 ## controller/MiNiFiController.cpp: ## @@ -15,57 +15,52 @@ * See the License for the specific language governing permissions and * limitations under the

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1503: MINIFICPP-2039 Dust off minificontroller

lordgamez commented on code in PR #1503: URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1108569955 ## controller/tests/ControllerTests.cpp: ## @@ -0,0 +1,479 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor