[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1532: MINIFICPP-2076 Implement logging metrics publisher

2023-06-08 Thread via GitHub
lordgamez commented on code in PR #1532: URL: https://github.com/apache/nifi-minifi-cpp/pull/1532#discussion_r1222652869 ## libminifi/src/core/state/LogMetricsPublisher.cpp: ## @@ -0,0 +1,129 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1532: MINIFICPP-2076 Implement logging metrics publisher

2023-06-02 Thread via GitHub
lordgamez commented on code in PR #1532: URL: https://github.com/apache/nifi-minifi-cpp/pull/1532#discussion_r1214357557 ## METRICS.md: ## @@ -42,25 +42,66 @@ Aside from the publisher exposed metrics, metrics are also sent through C2 proto ## Configuration -To configure

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1532: MINIFICPP-2076 Implement logging metrics publisher

2023-05-22 Thread via GitHub
lordgamez commented on code in PR #1532: URL: https://github.com/apache/nifi-minifi-cpp/pull/1532#discussion_r1200685570 ## libminifi/test/unit/LogMetricsPublisherTests.cpp: ## @@ -0,0 +1,209 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1532: MINIFICPP-2076 Implement logging metrics publisher

2023-04-06 Thread via GitHub
lordgamez commented on code in PR #1532: URL: https://github.com/apache/nifi-minifi-cpp/pull/1532#discussion_r1159525848 ## docker/test/integration/features/core_functionality.feature: ## @@ -67,3 +67,9 @@ Feature: Core flow functionalities When all instances start up

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1532: MINIFICPP-2076 Implement logging metrics publisher

2023-03-29 Thread via GitHub
lordgamez commented on code in PR #1532: URL: https://github.com/apache/nifi-minifi-cpp/pull/1532#discussion_r1152057845 ## docker/test/integration/features/core_functionality.feature: ## @@ -67,3 +67,9 @@ Feature: Core flow functionalities When all instances start up