[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

2023-04-20 Thread via GitHub
lordgamez commented on code in PR #1562: URL: https://github.com/apache/nifi-minifi-cpp/pull/1562#discussion_r1172352494 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -73,6 +73,11 @@ void PutS3Object::onSchedule(const std::shared_ptr }

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

2023-04-20 Thread via GitHub
lordgamez commented on code in PR #1562: URL: https://github.com/apache/nifi-minifi-cpp/pull/1562#discussion_r1172254661 ## extensions/aws/tests/MockS3RequestSender.h: ## @@ -250,6 +252,10 @@ class MockS3RequestSender : public minifi::aws::s3::S3RequestSender { return