lordgamez commented on code in PR #1564:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1564#discussion_r1214165734
##########
extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp:
##########
@@ -65,6 +65,28 @@ class SimpleFormatTestController : public
OutputFormatTestController {
}
};
+class LogFileTestController : public OutputFormatTestController {
+ public:
+ LogFileTestController(): OutputFormatTestController("", "*", "JSON",
"Simple") {
+ log_file_ = createTempDirectory() / "cwel-events.evtx";
+ channel_ = "SavedLog:" + log_file_.string();
+ }
+
+ protected:
+ void dispatchBookmarkEvent() override {
+ reportEvent(APPLICATION_CHANNEL, "Event zero from file: this is in the
past");
+ generateLogFile(std::wstring{APPLICATION_CHANNEL.begin(),
APPLICATION_CHANNEL.end()}, log_file_);
Review Comment:
Oh I see now, thanks for clarifying! You are right, it should be unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
