[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1013921335 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,582 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1013917235 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,582 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1013916908 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,582 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1013913817 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,582 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011835200 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011816544 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011666740 ## libminifi/include/utils/StringUtils.h: ## @@ -37,6 +37,19 @@ #include "utils/gsl.h" #include "utils/meta/detected.h" +// libc++ doesn't define

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011665191 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011662554 ## extensions/standard-processors/processors/PutTCP.h: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011661453 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011660327 ## extensions/standard-processors/tests/unit/PutTCPTests.cpp: ## @@ -0,0 +1,454 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1011658749 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005559661 ## extensions/standard-processors/processors/PutTCP.h: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005559282 ## extensions/standard-processors/tests/unit/resources/ca_B.crt: ## @@ -0,0 +1,21 @@ +-BEGIN CERTIFICATE- Review Comment: Its not invalid per

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005559107 ## extensions/standard-processors/tests/unit/PutTCPTests.cpp: ## @@ -0,0 +1,454 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005557987 ## extensions/standard-processors/tests/unit/PutTCPTests.cpp: ## @@ -0,0 +1,454 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005557725 ## extensions/standard-processors/tests/unit/PutTCPTests.cpp: ## @@ -0,0 +1,454 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005557011 ## extensions/standard-processors/tests/unit/PutTCPTests.cpp: ## @@ -0,0 +1,454 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005556676 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r100380 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r100073 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -0,0 +1,551 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005553979 ## libminifi/include/utils/StringUtils.h: ## @@ -37,6 +37,19 @@ #include "utils/gsl.h" #include "utils/meta/detected.h" +// libc++ doesn't define

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1419: MINIFICPP-1934 PutTCP processor

martinzink commented on code in PR #1419: URL: https://github.com/apache/nifi-minifi-cpp/pull/1419#discussion_r1005553207 ## PROCESSORS.md: ## @@ -2167,6 +2168,32 @@ In the list below, the names of required properties appear in bold. Any other pr | success | After a