[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165182366 ## extensions/aws/CMakeLists.txt: ## Review Comment: I think something like ``` if (CMAKE_SYSTEM_PROCESSOR MATCHES "(aarch64)|(arm64)")

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
martinzink commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165135660 ## extensions/aws/CMakeLists.txt: ## Review Comment: Now with this fix, it seems we can remove the workarounds I've included in MINIFICPP-2048 that