martinzink commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1221354436
##
libminifi/src/TimerDrivenSchedulingAgent.cpp:
##
@@ -28,11 +28,13 @@ namespace org::apache::nifi::minifi {
utils::TaskRescheduleInfo
martinzink commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1214604135
##
libminifi/src/TimerDrivenSchedulingAgent.cpp:
##
@@ -28,11 +28,13 @@ namespace org::apache::nifi::minifi {
utils::TaskRescheduleInfo
martinzink commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1211807969
##
libminifi/src/utils/ThreadPool.cpp:
##
@@ -151,10 +153,10 @@ void ThreadPool::manageWorkers() {
if (nullptr != thread_manager_) {
while
martinzink commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1211802167
##
libminifi/src/core/Processor.cpp:
##
@@ -372,26 +372,26 @@ void Processor::setMaxConcurrentTasks(const uint8_t
tasks) {
}
void Processor::yield() {
martinzink commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1211800505
##
libminifi/include/utils/ThreadPool.h:
##
@@ -94,7 +94,7 @@ class Worker {
promise->set_value(result);
return false;
}
-
martinzink commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1211801649
##
libminifi/test/unit/ThreadPoolTests.cpp:
##
Review Comment:
Replaced these with lambdas in
