msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-615490345
Closing this PR in lieu of MINIFICPP-1008. Incorporated ECU core related
comments there. Will revisit C2 part of nanofi from this PR in near
msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-578846776
> > Besides the comments added my main concern is that I still don't feel
convinced about the need of implementing thread pools, message
msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-561880970
> Besides the comments added my main concern is that I still don't feel
convinced about the need of implementing thread pools, message
msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-558744961
> @msharee9 Just started the review, I am releasing what I have so far, but
I have fundamental questions before continuing the C2 part of
msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-558721337
> Next batch of review.
>
> A general observation:
> The new mass of code uses a huge amount of pthread functions. This means
that
msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-558719974
> I don't think we should implement ringbuffer and threadpool.
> Did you check for solutions already available on github? (considering
msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-558324183
Please hold off code review on this pull request. There seemed to be a
mistake from my side while pushing rebased commit to this branch. It
msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-558324255
Please hold off code review on this pull request. There seemed to be a
mistake from my side while pushing rebased commit to this branch. It
