[GitHub] [nifi-minifi-cpp] phrocker commented on issue #595: Add windows tests

2019-08-16 Thread GitBox
phrocker commented on issue #595: Add windows tests URL: https://github.com/apache/nifi-minifi-cpp/pull/595#issuecomment-522021954 @apiri thanks. pushed another fix for a unit test and to remove cout statements. will wait for a +1 to merge.

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #595: Add windows tests

2019-08-15 Thread GitBox
phrocker commented on issue #595: Add windows tests URL: https://github.com/apache/nifi-minifi-cpp/pull/595#issuecomment-521701362 @apiri @arpadboda was that comment a +1? I added some code to fix some bugs in tests. Some windows tests fail but I think we can address those later. ---

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #595: Add windows tests

2019-07-19 Thread GitBox
phrocker commented on issue #595: Add windows tests URL: https://github.com/apache/nifi-minifi-cpp/pull/595#issuecomment-513280391 @apiri I know you've comfortable with windows builds so would you be able to take run some tests to make sure everything works on your windows platforrms? A f