szaszm commented on a change in pull request #1144:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1144#discussion_r682170512
##
File path: libminifi/test/unit/ProcessSessionTests.cpp
##
@@ -31,25 +32,16 @@ REGISTER_RESOURCE(DummyProcessor, "A processor that does
szaszm commented on a change in pull request #1144:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1144#discussion_r680313572
##
File path: extensions/systemd/ConsumeJournald.cpp
##
@@ -23,6 +23,7 @@
#include "date/date.h"
#include "spdlog/spdlog.h" // TODO(szaszm):
szaszm commented on a change in pull request #1144:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1144#discussion_r679874978
##
File path: libminifi/include/utils/StringUtils.h
##
@@ -17,24 +17,23 @@
#ifndef LIBMINIFI_INCLUDE_UTILS_STRINGUTILS_H_
#define
szaszm commented on a change in pull request #1144:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1144#discussion_r679874978
##
File path: libminifi/include/utils/StringUtils.h
##
@@ -17,24 +17,23 @@
#ifndef LIBMINIFI_INCLUDE_UTILS_STRINGUTILS_H_
#define
szaszm commented on a change in pull request #1144:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1144#discussion_r677564097
##
File path: encrypt-config/ArgParser.h
##
@@ -48,20 +48,20 @@ class Arguments {
void set(const std::string& bool_key);
- static
szaszm commented on a change in pull request #1144:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1144#discussion_r677564097
##
File path: encrypt-config/ArgParser.h
##
@@ -48,20 +48,20 @@ class Arguments {
void set(const std::string& bool_key);
- static
