[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

szaszm commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r466282492 ## File path: libminifi/include/io/CRCStream.h ## @@ -224,7 +222,7 @@ template int CRCStream::readData(uint8_t *buf, int buflen) { int ret = chil

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

szaszm commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r465624329 ## File path: libminifi/src/sitetosite/SiteToSiteClient.cpp ## @@ -499,8 +499,9 @@ int16_t SiteToSiteClient::send(std::string transactionID, DataPac

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

szaszm commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463077312 ## File path: extensions/expression-language/Expression.cpp ## @@ -194,9 +194,12 @@ Value expr_toLower(const std::vector &args) { Value expr_subst