szaszm commented on a change in pull request #895:
URL: https://github.com/apache/nifi-minifi-cpp/pull/895#discussion_r488243927
##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -115,14 +115,15 @@ class FileUtils {
* @param force_posix returns the posix path separator ('/'), even when not
on posix. Useful when dealing with remote posix paths.
* @return the path separator character
*/
- static char get_separator(bool force_posix = false) {
#ifdef WIN32
+ static char get_separator(bool force_posix = false) {
Review comment:
I'd keep this outside the `#ifdef` to avoid confusing simple editors
with the multiple braces. Use `(void)force_posix;` inside the function body to
suppress the warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
