[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
szaszm commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165478090 ## .github/workflows/ci.yml: ## Review Comment: In the meantime, maybe we could do something like this: ``` make docker-verify-q1 & make

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-03-28 Thread via GitHub
szaszm commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1150109878 ## .github/workflows/ci.yml: ## Review Comment: I think it would be better to run the 4 parallel jobs on the same VM, to save cloud resources. With this

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-03-28 Thread via GitHub
szaszm commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1150109878 ## .github/workflows/ci.yml: ## Review Comment: I think it would be better to run the 4 parallel jobs on the same VM, to save cloud resources. Maybe we

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-03-28 Thread via GitHub
szaszm commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1150109878 ## .github/workflows/ci.yml: ## Review Comment: I think it would be better to run the 4 parallel jobs on the same VM, to save cloud resources. Maybe we

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-03-21 Thread via GitHub
szaszm commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1143315975 ## .github/workflows/ci.yml: ## @@ -223,13 +227,132 @@ jobs: if [ -d ~/.ccache ]; then mv ~/.ccache .; fi mkdir build cd build