Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
build with RAT and linter looks good
verified functionality
code changes look good in response to those items suggested prior. will
get this merged
---
If your project is set up for
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
@phrocker looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
@benqiu2016
1) Yes, I have run for two days. Have also run valgrind to show no memory
leaks
2) Yes, and in this case I would encourage the users to use the file
system based
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
it is a very large commit. Overall looks good .
Couple of comments over all
1) for the volatile repo, have we run the some test over night and monitor
the memory to see whether we
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
As a general comment, let's have the ability to minimize locking and not
minimize locking in volatile content repository.
---
If your project is set up for it, you can reply to this email
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
Okay, thanks for update. Will wait for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
Adding one more commit to close this out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
There are travis failures. Will address.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
I will be self reviewing this in a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
11 matches
Mail list logo
