Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj no worries, I'll get this merged. Thanks
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker That was the last one, I promise.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj We also haven't explored disabling optimizations to speed up catch
builds or using CATCH_CONFIG_FAST_COMPILE ( which is supposed to help by 20% )
for travis builds.
On my
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj It's not archive that is the problem. It's the usage of uint64_t
over long. *
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
The build fails both with or without the `struct` keyword; I'll try a
different approach next. There are also some other things I forgot to add when
moving to the extension.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker I already have a travis-ci.org account, but I've granted access
to @NifiLocal and synced the account.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj I emailed Travis
their response:
""
We've been experiencing some issues with our abuse system creating false
positives lately, and I suspect that's what's happening
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker Cool. I can squash into one commit and force push, if needed.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj thanks for the fix. Something in the way this PR is submitted is
causing travis not to run as as result I"ll go through re-verification on all
platforms and merge once I have an
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj Ignore the boost removal, that was unrelated. This processor will
be moved to an EXCLUDE_BOOST so that those who wish to exclude boost will not
see this and other libarchive
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
I'm changing the types for size, mtime and mtime_nsec in
`ArchiveEntryMetadata`'s declaration instead of casting. Why'd you take out the
boost header include?
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
diff --git a/libminifi/src/processors/FocusArchiveEntry.cpp
b/libminifi/src/processors/FocusArchiveEntry.cpp
index c262217..42962a6 100644
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj These failures are isolated to OSX. I noticed that travis isn't
building your PRs to show you the build failure. I'll take a look to see why
you aren't getting travis runs. My
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker For the first error, I'm pretty sure the only type it can convert
to is int64. The JsonCPP docs don't have any ambiguities there, it's just
signed and unsigned int and int64.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj I see two build failures.
FocusArchiveEntry.cpp:161:38: error: ambiguous conversion for
functional-style cast from 'const long' to 'Json::Value'
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
Thank @achristianson for the original implementation, way back in
March/April against 070d8758fded4836f17816c1b1a34a48aa1bba20. I just brought it
up to date.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker With that header addition I believe we should be good to go.
Thanks!
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj One minor change RE the license header for
ProcessSessionReadCallback. Assuming @apiri is good, we can merge. I'm going to
make a follow on to break these archive classes into an
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
Rebased.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj pls clarify with @phrocker if the stream-based export is truly
necessary at this point.
The greater concern may be ensuring that the stash resource claims are
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
Things left to look into:
* [ ] Move things which depend on libarchive to an extension
* [ ] Use streams for exportContent
* [ ] Move exportContent ReadCallback to another file
21 matches
Mail list logo
