[GitHub] nifi-minifi-cpp issue #286: MINIFICPP-438: Preform string to correct test fa...

2018-03-21 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/286 Fixed the decode method in #290 ---

[GitHub] nifi-minifi-cpp issue #286: MINIFICPP-438: Preform string to correct test fa...

2018-03-20 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/286 @achristianson i agreed that something else should likely be done. Feel free to take that on. My goal was to solve the test failure. ---

[GitHub] nifi-minifi-cpp issue #286: MINIFICPP-438: Preform string to correct test fa...

2018-03-20 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/286 ...also I think it would need to be ```json ["string val"] ``` or ```json {"dummy_key": "string_val"} ``` to really be universally valid, not just

[GitHub] nifi-minifi-cpp issue #286: MINIFICPP-438: Preform string to correct test fa...

2018-03-20 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/286 I looked into this and it's really a problem with the escape/unescape JSON. We're not aiming to parse/unparse a JSON object, but rather to prepare a string for use in JSON. The escape/

[GitHub] nifi-minifi-cpp issue #286: MINIFICPP-438: Preform string to correct test fa...

2018-03-20 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/286 My intent was to not form a valid JSON document but to instead continue the spirit of the test. ---